linux-kernel - Re: [PATCH net-next] net: ethtool: Fix out-of-bounds copy to user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKgT0UeePd_+UwpGTT_v7nacf=yLoravtEZ2-gN4dpeWC5AsBg@mail.gmail.com>
Date:   Fri, 9 Jun 2023 10:59:25 -0700
From:   Alexander Duyck <alexander.duyck@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Ding Hui <dinghui@...gfor.com.cn>, Andrew Lunn <andrew@...n.ch>,
        davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        pengdonglin@...gfor.com.cn, huangcun@...gfor.com.cn
Subject: Re: [PATCH net-next] net: ethtool: Fix out-of-bounds copy to user

On Fri, Jun 9, 2023 at 10:13 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Fri, 9 Jun 2023 23:25:34 +0800 Ding Hui wrote:
> > drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c: .get_sset_count         = nfp_net_get_sset_count,
> > drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c: .get_sset_count         = nfp_port_get_sset_count,
>
> Not sure if your research is accurate, NFP does not change the number
> of stats. The number depends on the device and the FW loaded, but those
> are constant during a lifetime of a netdevice.

Yeah, the value doesn't need to be a constant, it just need to be constant.

So for example in the ixgbe driver I believe we were using the upper
limits on the Tx and Rx queues which last I recall are stored in the
netdev itself.