linux-kernel - Re: [PATCH v9 2/4] tpm: of: Make of-tree specific function commonly available

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <CT8BRJZS8RQU.9ICEA2UAFC7G@suppilovahvero>
Date:   Fri, 09 Jun 2023 21:18:32 +0300
From:   "Jarkko Sakkinen" <jarkko@...nel.org>
To:     "Jerry Snitselaar" <jsnitsel@...hat.com>,
        "Stefan Berger" <stefanb@...ux.ibm.com>
Cc:     <kexec@...ts.infradead.org>, <devicetree@...r.kernel.org>,
        <linux-integrity@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linuxppc-dev@...ts.ozlabs.org>, <nayna@...ux.ibm.com>,
        <nasastry@...ibm.com>, <mpe@...erman.id.au>,
        "Jason Gunthorpe" <jgg@...pe.ca>,
        "Rob Herring" <robh+dt@...nel.org>,
        "Frank Rowand" <frowand.list@...il.com>,
        "Mimi Zohar" <zohar@...ux.ibm.com>,
        "Nageswara R Sastry" <rnsastry@...ux.ibm.com>,
        "Coiby Xu" <coxu@...hat.com>
Subject: Re: [PATCH v9 2/4] tpm: of: Make of-tree specific function commonly
 available

On Thu May 25, 2023 at 1:56 AM EEST, Jerry Snitselaar wrote:
> On Tue, Apr 18, 2023 at 09:44:07AM -0400, Stefan Berger wrote:
> > Simplify tpm_read_log_of() by moving reusable parts of the code into
> > an inline function that makes it commonly available so it can be
> > used also for kexec support. Call the new of_tpm_get_sml_parameters()
> > function from the TPM Open Firmware driver.
> > 
> > Signed-off-by: Stefan Berger <stefanb@...ux.ibm.com>
> > Cc: Jarkko Sakkinen <jarkko@...nel.org>
> > Cc: Jason Gunthorpe <jgg@...pe.ca>
> > Cc: Rob Herring <robh+dt@...nel.org>
> > Cc: Frank Rowand <frowand.list@...il.com>
> > Reviewed-by: Mimi Zohar <zohar@...ux.ibm.com>
> > Tested-by: Nageswara R Sastry <rnsastry@...ux.ibm.com>
> > Tested-by: Coiby Xu <coxu@...hat.com>
> > Acked-by: Jarkko Sakkinen <jarkko@...nel.org>
> > 
>
> Reviewed-by: Jerry Snitselaar <jsnitsel@...hat.com>

If I just pick tpm only patches they won't apply so maybe TPM changes
should be better separated if that is by any means possible.

Open for counter proposals. Just my thoughts...

I.e. I'm mainly wondering why TPM patches depend on IMA patches?

BR, Jarkko