linux-kernel - Re: [RESEND 14/15] drm/radeon/radeon_ttm: Remove unused variable 'rbo' from radeon_bo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADnq5_OpT29qg+dbqEmkRKP1-OqEV1QqPU7Wyd0AV1idHAJ4Sw@mail.gmail.com>
Date:   Fri, 9 Jun 2023 15:03:36 -0400
From:   Alex Deucher <alexdeucher@...il.com>
To:     Lee Jones <lee@...nel.org>
Cc:     "Pan, Xinhui" <Xinhui.Pan@....com>, linux-kernel@...r.kernel.org,
        amd-gfx@...ts.freedesktop.org,
        Jerome Glisse <glisse@...edesktop.org>,
        dri-devel@...ts.freedesktop.org, Daniel Vetter <daniel@...ll.ch>,
        Alex Deucher <alexander.deucher@....com>,
        David Airlie <airlied@...il.com>,
        Christian König <christian.koenig@....com>
Subject: Re: [RESEND 14/15] drm/radeon/radeon_ttm: Remove unused variable
 'rbo' from radeon_bo_move()

This patch is no longer applicable.

Alex

On Fri, Jun 9, 2023 at 4:18 AM Lee Jones <lee@...nel.org> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
>  drivers/gpu/drm/radeon/radeon_ttm.c: In function ‘radeon_bo_move’:
>  drivers/gpu/drm/radeon/radeon_ttm.c:201:27: warning: variable ‘rbo’ set but not used [-Wunused-but-set-variable]
>
> Cc: Alex Deucher <alexander.deucher@....com>
> Cc: "Christian König" <christian.koenig@....com>
> Cc: "Pan, Xinhui" <Xinhui.Pan@....com>
> Cc: David Airlie <airlied@...il.com>
> Cc: Daniel Vetter <daniel@...ll.ch>
> Cc: Jerome Glisse <glisse@...edesktop.org>
> Cc: amd-gfx@...ts.freedesktop.org
> Cc: dri-devel@...ts.freedesktop.org
> Signed-off-by: Lee Jones <lee@...nel.org>
> ---
>  drivers/gpu/drm/radeon/radeon_ttm.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
> index 4eb83ccc4906a..de4e6d78f1e12 100644
> --- a/drivers/gpu/drm/radeon/radeon_ttm.c
> +++ b/drivers/gpu/drm/radeon/radeon_ttm.c
> @@ -197,7 +197,6 @@ static int radeon_bo_move(struct ttm_buffer_object *bo, bool evict,
>  {
>         struct ttm_resource *old_mem = bo->resource;
>         struct radeon_device *rdev;
> -       struct radeon_bo *rbo;
>         int r;
>
>         if (new_mem->mem_type == TTM_PL_TT) {
> @@ -210,7 +209,6 @@ static int radeon_bo_move(struct ttm_buffer_object *bo, bool evict,
>         if (r)
>                 return r;
>
> -       rbo = container_of(bo, struct radeon_bo, tbo);
>         rdev = radeon_get_rdev(bo->bdev);
>         if (!old_mem || (old_mem->mem_type == TTM_PL_SYSTEM &&
>                          bo->ttm == NULL)) {
> --
> 2.41.0.162.gfafddb0af9-goog
>