linux-kernel - Re: [PATCH v2 2/2] NFC: nxp-nci: Add pad supply voltage pvdd-supply

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 09 Jun 2023 20:52:47 +0000
From:   Raymond Hackley <raymondhackley@...tonmail.com>
To:     broonie@...nel.org
Cc:     davem@...emloft.net, devicetree@...r.kernel.org,
        edumazet@...gle.com, jk@...econstruct.com.au,
        krzysztof.kozlowski@...aro.org, kuba@...nel.org,
        lgirdwood@...il.com, linux-kernel@...r.kernel.org,
        michael@...le.cc, netdev@...r.kernel.org, pabeni@...hat.com,
        raymondhackley@...tonmail.com, robh+dt@...nel.org,
        u.kleine-koenig@...gutronix.de
Subject: Re: [PATCH v2 2/2] NFC: nxp-nci: Add pad supply voltage pvdd-supply

Hi Mark,

On Friday, June 9th, 2023 at 7:34 PM, Mark Brown <broonie@...nel.org> wrote:
 
> Specifically your driver should only ever call regulator_disable() to
> balance out regulator_enable() calls it made itself and it should know
> how many of those it has done. regulator_is_enabled() should only ever
> be used during probe if for some reason it is important to figure out if
> the device is already powered for startup, this should be very unusual.
> If something else enabled the regualtor then whatever did that needs to
> undo those enables, not another driver.

Thnak you for explanation. I should drop regulator_is_enabled() here since
it's misused.

Regards,
Raymond