linux-kernel - Re: [tip: objtool/core] x86/orc: Make the is_callthunk() definition depend on CONFIG_BPF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 9 Jun 2023 14:24:20 -0700
From:   Josh Poimboeuf <jpoimboe@...nel.org>
To:     tip-bot2 for Ingo Molnar <tip-bot2@...utronix.de>
Cc:     linux-tip-commits@...r.kernel.org, Ingo Molnar <mingo@...nel.org>,
        linux-kernel@...r.kernel.org,
        Peter Zijlstra <peterz@...radead.org>, x86@...nel.org
Subject: Re: [tip: objtool/core] x86/orc: Make the is_callthunk() definition
 depend on CONFIG_BPF_JIT=y

On Fri, Jun 09, 2023 at 09:18:13AM -0000, tip-bot2 for Ingo Molnar wrote:
> The following commit has been merged into the objtool/core branch of tip:
> 
> Commit-ID:     301cf77e21317b3465c5e2bb0188df24bbf1c2e2
> Gitweb:        https://git.kernel.org/tip/301cf77e21317b3465c5e2bb0188df24bbf1c2e2
> Author:        Ingo Molnar <mingo@...nel.org>
> AuthorDate:    Fri, 09 Jun 2023 11:04:53 +02:00
> Committer:     Ingo Molnar <mingo@...nel.org>
> CommitterDate: Fri, 09 Jun 2023 11:09:04 +02:00
> 
> x86/orc: Make the is_callthunk() definition depend on CONFIG_BPF_JIT=y
> 
> Recent commit:
> 
>   020126239b8f Revert "x86/orc: Make it callthunk aware"
> 
> Made the only user of is_callthunk() depend on CONFIG_BPF_JIT=y, while
> the definition of the helper function is unconditional.
> 
> Move is_callthunk() inside the #ifdef block.
> 
> Addresses this build failure:
> 
>    arch/x86/kernel/callthunks.c:296:13: error: ‘is_callthunk’ defined but not used [-Werror=unused-function]

Sorry about that.  The bots didn't complain for some reason :-/

-- 
Josh