linux-kernel - Re: linux-next: Signed-off-by missing for commit in the rcu tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20230609040804.164292-1-falcon@tinylab.org>
Date:   Fri,  9 Jun 2023 12:08:04 +0800
From:   Zhangjin Wu <falcon@...ylab.org>
To:     sfr@...b.auug.org.au
Cc:     falcon@...ylab.org, linux-kernel@...r.kernel.org,
        linux-next@...r.kernel.org, paulmck@...nel.org, w@....eu
Subject: Re: linux-next: Signed-off-by missing for commit in the rcu tree

Hi, Stephen, Willy, Thomas, Paul

> Hi all,
> 
> Sorry, the subject should have been "linux-next: fixes tag needs work
> in rcu tree".
> 
> On Fri, 9 Jun 2023 08:27:22 +1000 Stephen Rothwell <sfr@...b.auug.org.au> w=
> rote:
> >
> > In commit
> >=20
> >   df772c12508a ("selftests/nolibc: syscall_args: use generic __NR_statx")
> >=20
> > Fixes tag
> >=20
> >   Fixes: 8e3ab529bef9 ("tools/nolibc/unistd: add syscall()")
> >=20
> > has these problem(s):
> >=20
> >   - Target SHA1 does not exist
> >=20
> > Maybe you meant
> >=20
> > Fixes: 6bff2a1e97e3 ("tools/nolibc/unistd: add syscall()")

Thanks, just checked the rcu/next branch of Paul, the commit is really the one
you corrected:

    Fixes: 6bff2a1e97e3 ("tools/nolibc/unistd: add syscall()")

Willy, this happened may be because of the 'int' to 'long' fixup merged to the
old "tools/nolibc/unistd: add syscall()" commit, I forgot the check of this
change in my patch.

Btw, perhaps it is possible to merge this typo fixup (tools/nolibc: fix up typo
_sycall_narg -> _syscall_narg) [1] to this commit too:

    6bff2a1e97e3 ("tools/nolibc/unistd: add syscall()")

And then update the new 'Fixes' tag in this patch:

    df772c12508a ("selftests/nolibc: syscall_args: use generic __NR_statx")

Or even merge both of them to the first one, and eventually, no Fixes lines
required.

As a summary, the following two fixes:

    df772c12508a ("selftests/nolibc: syscall_args: use generic __NR_statx")

    not merged   ("tools/nolibc: fix up typo _sycall_narg -> _syscall_narg"), see [1]

are for this one:

    6bff2a1e97e3 ("tools/nolibc/unistd: add syscall()")

Merging both of them to the above one may be a choice ;-)

Best Regards,
Zhangjin

[1]: https://lore.kernel.org/lkml/64f663e9e024564a7baca6769394f1e7d5a0422c.1686230738.git.falcon@tinylab.org/