linux-kernel - Re: [PATCH] pinctrl: sunplus: Delete an unnecessary check before kfree() in sppctl_dt_node_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CACRpkdbe2AjD69tpgDDJKf0ge__hoTs72OuT9M-p21_q+z3f8w@mail.gmail.com>
Date:   Fri, 9 Jun 2023 09:32:40 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Markus Elfring <Markus.Elfring@....de>,
        Lu Hongfei <luhongfei@...o.com>
Cc:     kernel-janitors@...r.kernel.org, linux-gpio@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        Dvorkin Dmitry <dvorkin@...bo.com>,
        Wells Lu <wellslutw@...il.com>,
        LKML <linux-kernel@...r.kernel.org>, cocci@...ia.fr,
        Wells Lu <wells.lu@...plus.com>
Subject: Re: [PATCH] pinctrl: sunplus: Delete an unnecessary check before
 kfree() in sppctl_dt_node_to_map()

On Tue, Jun 6, 2023 at 3:26 PM Markus Elfring <Markus.Elfring@....de> wrote:

> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Tue, 6 Jun 2023 15:00:18 +0200
>
> It can be known that the function “kfree” performs a null pointer check
> for its input parameter.
> It is therefore not needed to repeat such a check before its call.
>
> Thus remove a redundant pointer check.
>
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>

Lu Hongfei sent a patch changing the code around this location
so I rebased it manually and applied, check the result, thanks!

Yours,
Linus Walleij