Message-ID: <c1c9a74a-bc5b-15ea-e5d2-8ec34bc921d@google.com>
Date:   Thu, 8 Jun 2023 17:54:33 -0700 (PDT)
From:   Hugh Dickins <hughd@...gle.com>
To:     Andrew Morton <akpm@...ux-foundation.org>
cc:     Mike Kravetz <mike.kravetz@...cle.com>,
        Mike Rapoport <rppt@...nel.org>,
        "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
        Matthew Wilcox <willy@...radead.org>,
        David Hildenbrand <david@...hat.com>,
        Suren Baghdasaryan <surenb@...gle.com>,
        Qi Zheng <zhengqi.arch@...edance.com>,
        Yang Shi <shy828301@...il.com>,
        Mel Gorman <mgorman@...hsingularity.net>,
        Peter Xu <peterx@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Will Deacon <will@...nel.org>, Yu Zhao <yuzhao@...gle.com>,
        Alistair Popple <apopple@...dia.com>,
        Ralph Campbell <rcampbell@...dia.com>,
        Ira Weiny <ira.weiny@...el.com>,
        Steven Price <steven.price@....com>,
        SeongJae Park <sj@...nel.org>,
        Lorenzo Stoakes <lstoakes@...il.com>,
        Huang Ying <ying.huang@...el.com>,
        Naoya Horiguchi <naoya.horiguchi@....com>,
        Christophe Leroy <christophe.leroy@...roup.eu>,
        Zack Rusin <zackr@...are.com>, Jason Gunthorpe <jgg@...pe.ca>,
        Axel Rasmussen <axelrasmussen@...gle.com>,
        Anshuman Khandual <anshuman.khandual@....com>,
        Pasha Tatashin <pasha.tatashin@...een.com>,
        Miaohe Lin <linmiaohe@...wei.com>,
        Minchan Kim <minchan@...nel.org>,
        Christoph Hellwig <hch@...radead.org>,
        Song Liu <song@...nel.org>,
        Thomas Hellstrom <thomas.hellstrom@...ux.intel.com>,
        Ryan Roberts <ryan.roberts@....com>,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: [PATCH v2 00/32] mm: allow pte_offset_map[_lock]() to fail

Here is v2 series of patches to mm, based on v6.4-rc5: preparing for
v2 effective changes to follow, probably next week (when I hope s390
will be sorted), affecting pte_offset_map() and pte_offset_map_lock().
There are very few differences from v1: noted patch by patch below.

This follows on from the v2 "arch: allow pte_offset_map[_lock]() to fail"
https://lore.kernel.org/linux-mm/a4963be9-7aa6-350-66d0-2ba843e1af44@google.com/
series of 23 posted on 2023-06-08,
replaces the v1 "mm: allow pte_offset_map[_lock]() to fail"
https://lore.kernel.org/linux-mm/68a97fbe-5c1e-7ac6-72c-7b9c6290b370@google.com/
series of 31 posted on 2023-05-21,
which was followed by the v1 "mm: free retracted page table by RCU"
https://lore.kernel.org/linux-mm/35e983f5-7ed3-b310-d949-9ae8b130cdab@google.com/
series of 12 posted on 2023-05-28.

The first two series are "independent":
neither depends for build or correctness on the other, but both series
must in before the third series is added to make the effective changes
(and it may be preferred to hold that one until the following release).

What is it all about?  Some mmap_lock avoidance i.e. latency reduction.
Initially just for the case of collapsing shmem or file pages to THPs;
but likely to be relied upon later in other contexts e.g. freeing of
empty page tables (but that's not work I'm doing).  mmap_write_lock
avoidance when collapsing to anon THPs?  Perhaps, but again that's not
work I've done: a quick attempt was not as easy as the shmem/file case.

I would much prefer not to have to make these small but wide-ranging
changes for such a niche case; but failed to find another way, and
have heard that shmem MADV_COLLAPSE's usefulness is being limited by
that mmap_write_lock it currently requires.

These changes (though of course not these exact patches) have been in
Google's data centre kernel for three years now: we do rely upon them.

What is this preparatory series about?

The current mmap locking will not be enough to guard against that
tricky transition between pmd entry pointing to page table, and empty
pmd entry, and pmd entry pointing to huge page: pte_offset_map() will
have to validate the pmd entry for itself, returning NULL if no page
table is there.  What to do about that varies: sometimes nearby error
handling indicates just to skip it; but in many cases an ACTION_AGAIN or
"goto again" is appropriate (and if that risks an infinite loop, then
there must have been an oops, or pfn 0 mistaken for page table, before).

Given the likely extension to freeing empty page tables, I have not
limited this set of changes to a THP config; and it has been easier,
and sets a better example, if each site is given appropriate handling:
even where deeper study might prove that failure could only happen if
the pmd table were corrupted.

Several of the patches are, or include, cleanup on the way; and by the
end, pmd_trans_unstable() and suchlike are deleted: pte_offset_map() and
pte_offset_map_lock() then handle those original races and more.  Most
uses of pte_lockptr() are deprecated, with pte_offset_map_nolock()
taking its place.

This posting is based on v6.4-rc5, but good for any v6.4-rc; and good
for current mm-everything and linux-next, except for one minor clash in
mm/memory.c do_swap_page(), where Ryan Roberts and I fixed the same goto.

01/32 mm: use pmdp_get_lockless() without surplus barrier()
      v2: add acks from Yu Zhao and PeterX
02/32 mm/migrate: remove cruft from migration_entry_wait()s
      v2: add review from Alistair
03/32 mm/pgtable: kmap_local_page() instead of kmap_atomic()
      v2: same as v1
04/32 mm/pgtable: allow pte_offset_map[_lock]() to fail
      v2: same as v1
05/32 mm/filemap: allow pte_offset_map_lock() to fail
      v2: same as v1
06/32 mm/page_vma_mapped: delete bogosity in page_vma_mapped_walk()
      v2: same as v1
07/32 mm/page_vma_mapped: reformat map_pte() with less indentation
      v2: same as v1
08/32 mm/page_vma_mapped: pte_offset_map_nolock() not pte_lockptr()
      v2: same as v1
09/32 mm/pagewalkers: ACTION_AGAIN if pte_offset_map_lock() fails
      v2: add review from SeongJae for mm/damon part
10/32 mm/pagewalk: walk_pte_range() allow for pte_offset_map()
      v2: same as v1
11/32 mm/vmwgfx: simplify pmd & pud mapping dirty helpers
      v2: same as v1
12/32 mm/vmalloc: vmalloc_to_page() use pte_offset_kernel()
      v2: add review from Lorenzo
13/32 mm/hmm: retry if pte_offset_map() fails
      v2: add review from Alistair
14/32 fs/userfaultfd: retry if pte_offset_map() fails
      v2: add ack from PeterX
15/32 mm/userfaultfd: allow pte_offset_map_lock() to fail
      v2: use -EAGAIN instead of -EFAULT from PeterX
16/32 mm/debug_vm_pgtable,page_table_check: warn pte map fails
      v2: same as v1
17/32 mm/various: give up if pte_offset_map[_lock]() fails
      v2: removed mm/swap_state.c mod to a separate patch 31/32
18/32 mm/mprotect: delete pmd_none_or_clear_bad_unless_transhuge()
      v2: same as v1
19/32 mm/mremap: retry if either pte_offset_map_*lock() fails
      v2: same as v1
20/32 mm/madvise: clean up pte_offset_map_lock() scans
      v2: same as v1
21/32 mm/madvise: clean up force_shm_swapin_readahead()
      v2: same as v1
22/32 mm/swapoff: allow pte_offset_map[_lock]() to fail
      v2: same as v1
23/32 mm/mglru: allow pte_offset_map_nolock() to fail
      v2: add ack from Yu Zhao
24/32 mm/migrate_device: allow pte_offset_map_lock() to fail
      v2: add review from Alistair
25/32 mm/gup: remove FOLL_SPLIT_PMD use of pmd_trans_unstable()
      v2: add comment on -EBUSY from Yang Shi
26/32 mm/huge_memory: split huge pmd under one pte_offset_map()
      v2: add review from Yang Shi
27/32 mm/khugepaged: allow pte_offset_map[_lock]() to fail
      v2: add review from Yang Shi
28/32 mm/memory: allow pte_offset_map[_lock]() to fail
      v2: same as v1
29/32 mm/memory: handle_pte_fault() use pte_offset_map_nolock()
      v2: same as v1
30/32 mm/pgtable: delete pmd_trans_unstable() and friends
      v2: same as v1
31/32 mm/swap: swap_vma_readahead() do the pte_offset_map()
      v2: new patch replacing last part of v1 17/31
32/32 perf/core: Allow pte_offset_map() to fail
      v2: same as v1 31/31

 Documentation/mm/split_page_table_lock.rst |  17 ++-
 fs/proc/task_mmu.c                         |  32 ++---
 fs/userfaultfd.c                           |  21 +--
 include/linux/migrate.h                    |   4 +-
 include/linux/mm.h                         |  27 ++--
 include/linux/pgtable.h                    | 142 +++---------------
 include/linux/swap.h                       |  19 ---
 include/linux/swapops.h                    |  17 +--
 kernel/events/core.c                       |   4 +
 mm/damon/vaddr.c                           |  12 +-
 mm/debug_vm_pgtable.c                      |   9 +-
 mm/filemap.c                               |  25 ++--
 mm/gup.c                                   |  34 ++---
 mm/hmm.c                                   |   4 +-
 mm/huge_memory.c                           |  33 +++--
 mm/khugepaged.c                            |  83 ++++++-----
 mm/ksm.c                                   |  10 +-
 mm/madvise.c                               | 146 ++++++++++---------
 mm/mapping_dirty_helpers.c                 |  34 ++---
 mm/memcontrol.c                            |   8 +-
 mm/memory-failure.c                        |   8 +-
 mm/memory.c                                | 224 +++++++++++++----------------
 mm/mempolicy.c                             |   7 +-
 mm/migrate.c                               |  40 +++---
 mm/migrate_device.c                        |  31 +---
 mm/mincore.c                               |   9 +-
 mm/mlock.c                                 |   4 +
 mm/mprotect.c                              |  79 +++-------
 mm/mremap.c                                |  28 ++--
 mm/page_table_check.c                      |   2 +
 mm/page_vma_mapped.c                       |  97 +++++++------
 mm/pagewalk.c                              |  33 +++--
 mm/pgtable-generic.c                       |  56 ++++++++
 mm/swap_state.c                            |  45 +++---
 mm/swapfile.c                              |  38 ++---
 mm/userfaultfd.c                           |   8 ++
 mm/vmalloc.c                               |   3 +-
 mm/vmscan.c                                |  16 +--
 38 files changed, 662 insertions(+), 747 deletions(-)

Hugh

Powered by blists - more mailing lists