linux-kernel - Re: [PATCH v2] gpiolib: Fix GPIO chip IRQ initialization restriction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdZvV27wcp6ZxrUHtEC8+dydnH8_GJW9T97qROgfT1mZow@mail.gmail.com>
Date:   Fri, 9 Jun 2023 09:37:55 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Jiawen Wu <jiawenwu@...stnetic.com>
Cc:     brgl@...ev.pl, shreeya.patel@...labora.com,
        andy.shevchenko@...il.com, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] gpiolib: Fix GPIO chip IRQ initialization restriction

On Wed, Jun 7, 2023 at 10:20 AM Jiawen Wu <jiawenwu@...stnetic.com> wrote:

> In case of gpio-regmap, IRQ chip is added by regmap-irq and associated with
> GPIO chip by gpiochip_irqchip_add_domain(). The initialization flag was not
> added in gpiochip_irqchip_add_domain(), causing gpiochip_to_irq() to return
> -EPROBE_DEFER.
>
> Fixes: 5467801f1fcb ("gpio: Restrict usage of GPIO chip irq members before initialization")
> Signed-off-by: Jiawen Wu <jiawenwu@...stnetic.com>

Looks correct.
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours.
Linus Walleij