linux-kernel - Re: [PATCH V2] gpio: zynq: fix zynqmp_gpio not an immutable chip warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkda7TrNckpS5rLadv=eYRCDDN1qTBUp=jr+KfgoaQy8z7g@mail.gmail.com>
Date:   Fri, 9 Jun 2023 09:49:08 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Manikanta Guntupalli <manikanta.guntupalli@....com>
Cc:     michal.simek@...inx.com, michal.simek@....com, git@....com,
        shubhrajyoti.datta@...inx.com, srinivas.neeli@...inx.com,
        brgl@...ev.pl, linux-gpio@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        srinivas.goud@....com, manion05gk@...il.com
Subject: Re: [PATCH V2] gpio: zynq: fix zynqmp_gpio not an immutable chip warning

On Thu, Jun 8, 2023 at 8:43 PM Manikanta Guntupalli
<manikanta.guntupalli@....com> wrote:

> Make the struct irq_chip const and flag it as IRQCHIP_IMMUTABLE,
> call gpiochip_disable_irq() in the .irq_mask() callback and
> gpiochip_enable_irq() in the .irq_unmask() callback to fix
> "gpio gpiochip1: (zynqmp_gpio): not an immutable chip" warning.
>
> Signed-off-by: Manikanta Guntupalli <manikanta.guntupalli@....com>

This v2 looks good to me!
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij