linux-kernel - Re: [PATCH v2 1/2] kernel-doc: don't let V=1 change outcome

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87edmloxbr.fsf@meer.lwn.net>
Date:   Fri, 09 Jun 2023 02:26:48 -0600
From:   Jonathan Corbet <corbet@....net>
To:     Johannes Berg <johannes@...solutions.net>,
        linux-kernel@...r.kernel.org, linux-kbuild@...r.kernel.org,
        linux-doc@...r.kernel.org
Cc:     Masahiro Yamada <masahiroy@...nel.org>,
        Johannes Berg <johannes.berg@...el.com>
Subject: Re: [PATCH v2 1/2] kernel-doc: don't let V=1 change outcome

Johannes Berg <johannes@...solutions.net> writes:

> From: Johannes Berg <johannes.berg@...el.com>
>
> The kernel-doc script currently reports a number of issues
> only in "verbose" mode, but that's initialized from V=1
> (via KBUILD_VERBOSE), so if you use KDOC_WERROR=1 then
> adding V=1 might actually break the build. This is rather
> unexpected.
>
> Change kernel-doc to not change its behaviour wrt. errors
> (or warnings) when verbose mode is enabled, but rather add
> separate warning flags (and -Wall) for it. Allow enabling
> those flags via environment/make variables in the kernel's
> build system for easier user use, but to not have to parse
> them in the script itself.
>
> Signed-off-by: Johannes Berg <johannes.berg@...el.com>
> ---
> v2: - parse environment variables in build system rather than
>       the script itself, as suggested by Masahiro Yamada
>     - fix indentation

So this change seems fine to me; Masahiro, if you want to take these,
feel free to add:

Acked-by: Jonathan Corbet <corbet@....net>

Thanks,

jon