lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 9 Jun 2023 09:08:26 +0000
From:   <Claudiu.Beznea@...rochip.com>
To:     <walker.chen@...rfivetech.com>, <broonie@...nel.org>,
        <dan.carpenter@...aro.org>, <lgirdwood@...il.com>,
        <tiwai@...e.com>, <perex@...ex.cz>
CC:     <alsa-devel@...a-project.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 2/2] ASoC: starfive: Remove some unused macros

On 08.06.2023 16:57, Walker Chen wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> These macros are unused and can be dropped.
> 
> Signed-off-by: Walker Chen <walker.chen@...rfivetech.com>

Reviewed-by: Claudiu Beznea <claudiu.beznea@...rochip.com>


> ---
>  sound/soc/starfive/jh7110_tdm.c | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/sound/soc/starfive/jh7110_tdm.c b/sound/soc/starfive/jh7110_tdm.c
> index a9a3d52bdd2a..e4bdba20c499 100644
> --- a/sound/soc/starfive/jh7110_tdm.c
> +++ b/sound/soc/starfive/jh7110_tdm.c
> @@ -25,11 +25,8 @@
>  #include <sound/soc-dai.h>
> 
>  #define TDM_PCMGBCR                    0x00
> -       #define PCMGBCR_MASK            0x1e
>         #define PCMGBCR_ENABLE          BIT(0)
> -       #define PCMGBCR_TRITXEN         BIT(4)
>         #define CLKPOL_BIT              5
> -       #define TRITXEN_BIT             4
>         #define ELM_BIT                 3
>         #define SYNCM_BIT               2
>         #define MS_BIT                  1
> @@ -42,11 +39,6 @@
>         #define LRJ_BIT                 1
>  #define TDM_PCMRXCR                    0x08
>         #define PCMRXCR_RXEN            BIT(0)
> -       #define PCMRXCR_RXSL_MASK       0xc
> -       #define PCMRXCR_RXSL_16BIT      0x4
> -       #define PCMRXCR_RXSL_32BIT      0x8
> -       #define PCMRXCR_SCALE_MASK      0xf0
> -       #define PCMRXCR_SCALE_1CH       0x10
>  #define TDM_PCMDIV                     0x0c
> 
>  #define JH7110_TDM_FIFO                        0x170c0000
> --
> 2.17.1
> 

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ