linux-kernel - Re: [PATCH v2 3/4] pinctrl: intel: simplify exit path of set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230609092920.GQ45886@black.fi.intel.com>
Date:   Fri, 9 Jun 2023 12:29:20 +0300
From:   Mika Westerberg <mika.westerberg@...ux.intel.com>
To:     "Jadav, Raag" <raag.jadav@...el.com>
Cc:     "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "andriy.shevchenko@...ux.intel.com" 
        <andriy.shevchenko@...ux.intel.com>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Sangannavar, Mallikarjunappa" 
        <mallikarjunappa.sangannavar@...el.com>,
        "N, Pandith" <pandith.n@...el.com>
Subject: Re: [PATCH v2 3/4] pinctrl: intel: simplify exit path of set_mux hook

On Fri, Jun 09, 2023 at 09:10:42AM +0000, Jadav, Raag wrote:
> > On Fri, Jun 09, 2023 at 01:55:38PM +0530, Raag Jadav wrote:
> > > Simplify exit path of ->set_mux() hook and save a few bytes.
> > >
> > > add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-22 (-22)
> > > Function                                     old     new   delta
> > > intel_pinmux_set_mux                         242     220     -22
> > > Total: Before=10453, After=10431, chg -0.21%
> > >
> > > Signed-off-by: Raag Jadav <raag.jadav@...el.com>
> > > ---
> > >  drivers/pinctrl/intel/pinctrl-intel.c | 9 +++++----
> > >  1 file changed, 5 insertions(+), 4 deletions(-)
> > 
> > This adds one more line so it is not simplifying ;-)
> 
> Would "optimize" sound any better?

No, I think this patch is not useful at all.