linux-kernel - Re: [PATCH v2] mm/vmalloc: Replace the ternary conditional operator with min()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZIL5zehSOQTTXMBn@pc636>
Date:   Fri, 9 Jun 2023 12:07:09 +0200
From:   Uladzislau Rezki <urezki@...il.com>
To:     Lu Hongfei <luhongfei@...o.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Uladzislau Rezki <urezki@...il.com>,
        Christoph Hellwig <hch@...radead.org>,
        Lorenzo Stoakes <lstoakes@...il.com>,
        "open list:VMALLOC" <linux-mm@...ck.org>,
        open list <linux-kernel@...r.kernel.org>,
        opensource.kernel@...o.com
Subject: Re: [PATCH v2] mm/vmalloc: Replace the ternary conditional operator
 with min()

> It would be better to replace the traditional ternary conditional
> operator with min() in zero_iter
> 
> Signed-off-by: Lu Hongfei <luhongfei@...o.com>
> Reviewed-by: Lorenzo Stoakes <lstoakes@...il.com>
> ---
>  mm/vmalloc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> index 29077d61ff81..6125ed506895
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -3571,7 +3571,7 @@ static size_t zero_iter(struct iov_iter *iter, size_t count)
>  	while (remains > 0) {
>  		size_t num, copied;
>  
> -		num = remains < PAGE_SIZE ? remains : PAGE_SIZE;
> +		num = min_t(size_t, remains, PAGE_SIZE);
>  		copied = copy_page_to_iter_nofault(ZERO_PAGE(0), 0, num, iter);
>  		remains -= copied;
>  
> -- 
> 2.39.0
> 
I saw a complain from the robot. Indeed the min_t() variant is better:

Reviewed-by: Uladzislau Rezki (Sony) <urezki@...il.com>