linux-kernel - Re: [PATCH] block: fix rootwait= again

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <622e1132-3a66-de4d-9334-c63dcfd4c716@samsung.com>
Date:   Fri, 9 Jun 2023 12:55:35 +0200
From:   Marek Szyprowski <m.szyprowski@...sung.com>
To:     Christoph Hellwig <hch@....de>, axboe@...nel.dk
Cc:     festevam@...il.com, broonie@...nel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] block: fix rootwait= again

On 09.06.2023 07:17, Christoph Hellwig wrote:
> The previous rootwait fix added an -EINVAL return to a completely
> bogus superflous branch, fix this.
>
> Fixes: 1341c7d2ccf4 ("block: fix rootwait=")
> Reported-by: Mark Brown <broonie@...nel.org>
> Signed-off-by: Christoph Hellwig <hch@....de>
> Tested-by: Fabio Estevam <festevam@...il.com>

This fixes the issue I've found in today's next-20230609.

Tested-by: Marek Szyprowski <m.szyprowski@...sung.com>


> ---
>   block/early-lookup.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/early-lookup.c b/block/early-lookup.c
> index 48ea3e982419cc..a5be3c68ed079c 100644
> --- a/block/early-lookup.c
> +++ b/block/early-lookup.c
> @@ -181,7 +181,7 @@ static int __init devt_from_devname(const char *name, dev_t *devt)
>   	*p = '\0';
>   	*devt = blk_lookup_devt(s, part);
>   	if (*devt)
> -		return -ENODEV;
> +		return 0;
>   
>   	/* try disk name without p<part number> */
>   	if (p < s + 2 || !isdigit(p[-2]) || p[-1] != 'p')

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland