linux-kernel - Re: [PATCH] hwmon: (oxp-sensors) Add tt_toggle attribute on supported boards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABgtM3iOyCDgDY1gj-gJ4DXaXCY41FKzy-=miz0iiT8ywjbMHg@mail.gmail.com>
Date:   Fri, 9 Jun 2023 09:50:51 -0300
From:   Joaquin Aramendia <samsagax@...il.com>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     derekjohn.clark@...il.com, jdelvare@...e.com,
        linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hwmon: (oxp-sensors) Add tt_toggle attribute on supported boards

> Why don't you just attach the attribute to the platform device as I
> had suggested earlier ?

You mean I should do something like this in probe():

static int oxp_platform_probe(struct platform_device *pdev)
{
  ...

switch (board) {
    case aok_zoe_a1:
    case oxp_mini_amd_a07:
    case oxp_mini_amd_pro:
        pdev->dev.groups = oxp_ec_groups;
}
    hwdev = devm_hwmon_device_register_with_info(dev, "oxpec", NULL,
        &oxp_ec_chip_info, NULL);
...
}

Would that work? Or even be correct?
-- 
Joaquín I. Aramendía