linux-kernel - Re: [PATCH v9 2/4] tpm: of: Make of-tree specific function commonly available

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <CT8V1XE69DQ3.2JLQ9S20PK9OW@suppilovahvero>
Date:   Sat, 10 Jun 2023 12:25:25 +0300
From:   "Jarkko Sakkinen" <jarkko@...nel.org>
To:     "Stefan Berger" <stefanb@...ux.ibm.com>,
        "Jerry Snitselaar" <jsnitsel@...hat.com>
Cc:     <kexec@...ts.infradead.org>, <devicetree@...r.kernel.org>,
        <linux-integrity@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linuxppc-dev@...ts.ozlabs.org>, <nayna@...ux.ibm.com>,
        <nasastry@...ibm.com>, <mpe@...erman.id.au>,
        "Jason Gunthorpe" <jgg@...pe.ca>,
        "Rob Herring" <robh+dt@...nel.org>,
        "Frank Rowand" <frowand.list@...il.com>,
        "Mimi Zohar" <zohar@...ux.ibm.com>,
        "Nageswara R Sastry" <rnsastry@...ux.ibm.com>,
        "Coiby Xu" <coxu@...hat.com>
Subject: Re: [PATCH v9 2/4] tpm: of: Make of-tree specific function commonly
 available

On Fri Jun 9, 2023 at 9:49 PM EEST, Stefan Berger wrote:
>
>
> On 6/9/23 14:18, Jarkko Sakkinen wrote:
> > On Thu May 25, 2023 at 1:56 AM EEST, Jerry Snitselaar wrote:
> >> On Tue, Apr 18, 2023 at 09:44:07AM -0400, Stefan Berger wrote:
> >>> Simplify tpm_read_log_of() by moving reusable parts of the code into
> >>> an inline function that makes it commonly available so it can be
> >>> used also for kexec support. Call the new of_tpm_get_sml_parameters()
> >>> function from the TPM Open Firmware driver.
> >>>
> >>> Signed-off-by: Stefan Berger <stefanb@...ux.ibm.com>
> >>> Cc: Jarkko Sakkinen <jarkko@...nel.org>
> >>> Cc: Jason Gunthorpe <jgg@...pe.ca>
> >>> Cc: Rob Herring <robh+dt@...nel.org>
> >>> Cc: Frank Rowand <frowand.list@...il.com>
> >>> Reviewed-by: Mimi Zohar <zohar@...ux.ibm.com>
> >>> Tested-by: Nageswara R Sastry <rnsastry@...ux.ibm.com>
> >>> Tested-by: Coiby Xu <coxu@...hat.com>
> >>> Acked-by: Jarkko Sakkinen <jarkko@...nel.org>
> >>>
> >>
> >> Reviewed-by: Jerry Snitselaar <jsnitsel@...hat.com>
> > 
> > If I just pick tpm only patches they won't apply so maybe TPM changes
> > should be better separated if that is by any means possible.
>
> Per the comment here I am putting this series here on hold.
> https://lore.kernel.org/linux-integrity/20230418134409.177485-1-stefanb@linux.ibm.com/T/#m03745c2af2c46f19f329522fcb6ccb2bf2eaedc7

OK, cool.

I've mentioned this in few other emails but say this here too:
I was relocating for last couple of weeks, and thus some latency.
If you choose to repost the series, I'm happy to review it, thanks
:-)

BR, Jarkko