[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <58d3f250-499d-5a18-6798-f9833cc2dbbd@wanadoo.fr>
Date: Sat, 10 Jun 2023 16:07:51 +0200
From: Christophe JAILLET <christophe.jaillet@...adoo.fr>
To: Andi Shyti <andi.shyti@...nel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
Alim Akhtar <alim.akhtar@...sung.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Jiri Slaby <jirislaby@...nel.org>,
Thomas Abraham <thomas.abraham@...aro.org>,
Kukjin Kim <kgene.kim@...sung.com>,
linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
linux-samsung-soc@...r.kernel.org, linux-serial@...r.kernel.org
Subject: Re: [PATCH 1/2] tty: serial: samsung_tty: Fix a memory leak in
s3c24xx_serial_getclk() in case of error
Le 10/06/2023 à 12:26, Andi Shyti a écrit :
>> @@ -1459,8 +1459,10 @@ static unsigned int s3c24xx_serial_getclk(struct s3c24xx_uart_port *ourport,
>> continue;
>>
>> rate = clk_get_rate(clk);
>> - if (!rate)
>> + if (!rate) {
>> + clk_put(clk);
>> continue;
>
> could you also print an error here?
>
Is:
dev_err(ourport->port.dev,
"Failed to get clock rate for %s.\n", clkname);
fine for you?
CJ
Powered by blists - more mailing lists