linux-kernel - Re: [PATCH v3] meson saradc: fix clock divider mask length

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230610185918.7c85b66e@jic23-huawei>
Date:   Sat, 10 Jun 2023 18:59:18 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     andy.shevchenko@...il.com
Cc:     George Stark <gnstark@...rdevices.ru>, lars@...afoo.de,
        neil.armstrong@...aro.org, khilman@...libre.com,
        jbrunet@...libre.com, martin.blumenstingl@...glemail.com,
        andriy.shevchenko@...ux.intel.com, nuno.sa@...log.com,
        linux-iio@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-amlogic@...ts.infradead.org,
        kernel@...rdevices.ru
Subject: Re: [PATCH v3] meson saradc: fix clock divider mask length

On Wed, 7 Jun 2023 01:52:26 +0300
andy.shevchenko@...il.com wrote:

> Tue, Jun 06, 2023 at 07:53:57PM +0300, George Stark kirjoitti:
> > According to datasheets of supported meson SOCs length of ADC_CLK_DIV  
> 
> the datasheets
> 
> > field is 6 bits long. Although all supported SOCs have the register  
> 
> 6-bit
> 
> > with that field documented later SOCs use external clock rather than
> > ADC internal clock so this patch affects only meson8 family (S8* SOCs)  
> 
> s/SOC/SoC/g, and mind the grammar period at the end.
> 
> I believe Jonathan can fix when applying this, no need to resend unless
> he asks for it.
> 
Indeed - done and applied to the fixes-togreg branch of iio.git + marked it
for stable inclusion.

Thanks,

Jonathan

> FWIW,
> Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>
> 
> > Fixes: 3adbf3427330 ("iio: adc: add a driver for the SAR ADC found in Amlogic Meson SoCs")
> > Signed-off-by: George Stark <GNStark@...rdevices.ru>
> > ---
> > Changelog:
> > 
> > v1 -> v2:
> >     * Update commit message
> > v2 -> v3:
> >     * Update commit message
> > ---
> >  drivers/iio/adc/meson_saradc.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/iio/adc/meson_saradc.c b/drivers/iio/adc/meson_saradc.c
> > index 85b6826cc10c..b93ff42b8c19 100644
> > --- a/drivers/iio/adc/meson_saradc.c
> > +++ b/drivers/iio/adc/meson_saradc.c
> > @@ -72,7 +72,7 @@
> >  	#define MESON_SAR_ADC_REG3_PANEL_DETECT_COUNT_MASK	GENMASK(20, 18)
> >  	#define MESON_SAR_ADC_REG3_PANEL_DETECT_FILTER_TB_MASK	GENMASK(17, 16)
> >  	#define MESON_SAR_ADC_REG3_ADC_CLK_DIV_SHIFT		10
> > -	#define MESON_SAR_ADC_REG3_ADC_CLK_DIV_WIDTH		5
> > +	#define MESON_SAR_ADC_REG3_ADC_CLK_DIV_WIDTH		6
> >  	#define MESON_SAR_ADC_REG3_BLOCK_DLY_SEL_MASK		GENMASK(9, 8)
> >  	#define MESON_SAR_ADC_REG3_BLOCK_DLY_MASK		GENMASK(7, 0)
> >  
> > -- 
> > 2.38.4
> >   
>