[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <c7ca97c3-720b-494c-9865-b77252954a04@lunn.ch>
Date: Sun, 11 Jun 2023 17:11:58 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Jianhui Zhao <zhaojh329@...il.com>
Cc: davem@...emloft.net, edumazet@...gle.com, hkallweit1@...il.com,
kuba@...nel.org, linux-kernel@...r.kernel.org,
netdev@...r.kernel.org, pabeni@...hat.com
Subject: Re: [PATCH] net: mdio: fix duplicate registrations for phy with c45
in __of_mdiobus_register()
On Sun, Jun 11, 2023 at 10:57:28PM +0800, Jianhui Zhao wrote:
> Sorry, I misread the code.
So this is by code inspection, not an actual device tree booting on a
board?
What should happen is that __of_mdiobus_register() has:
/* Mask out all PHYs from auto probing. Instead the PHYs listed in
* the device tree are populated after the bus has been registered */
mdio->phy_mask = ~0;
So when
rc = __mdiobus_register(mdio, owner);
is called, no scanning happens. I _guess_ that is what you missed?
Andrew
--
pw-bot: reject
Powered by blists - more mailing lists