linux-kernel - Re: [PATCH v2] mux: mmio: depend on REGMAP as the code has that dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <113ce08f-743d-ac6c-f051-10f5f665e043@infradead.org>
Date:   Sun, 11 Jun 2023 14:13:31 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Peter Rosin <peda@...ntia.se>,
        Philipp Zabel <p.zabel@...gutronix.de>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] mux: mmio: depend on REGMAP as the code has that
 dependency



On 6/11/23 14:04, Peter Rosin wrote:
> Hi!
> 
> 2023-06-11 at 22:59, Randy Dunlap wrote:
>> On 5/24/23 05:52, Peter Rosin wrote:
>>> REGMAP is normally "selected", but that causes a recursive dependency.
>>> But since REGMAP is "depended on" in other places, do so here as well.
>>> The (implicit) REGMAP dependency was lost when the strict dependency
>>> on MFD_SYSCON was removed.
> 
> *snip*
> 
>>> diff --git a/drivers/mux/Kconfig b/drivers/mux/Kconfig
>>> index 80f015cf6e54..7f07ca06eb2b 100644
>>> --- a/drivers/mux/Kconfig
>>> +++ b/drivers/mux/Kconfig
>>> @@ -48,6 +48,7 @@ config MUX_GPIO
>>>  config MUX_MMIO
>>>  	tristate "MMIO/Regmap register bitfield-controlled Multiplexer"
>>>  	depends on OF
>>> +	depends on REGMAP
>>
>> REGMAP is mostly selected, not depended on, so preferably
>>
>> 	select REGMAP
>>
>> here whenever this patch is ready to be merged.
> 
> I would have preferred that as well, and if that was without problems I
> would not be so hesitant as there are really few pre-existing "depends
> on REGMAP".
> 
> I do not know what to do here and am not sure whom to ask for guidance.

Oh, I did not recall all of that, but now that  you mention it, I do remember
that problem (cyclic dependencies...).
Sorry about that.

-- 
~Randy