linux-kernel - Re: [PATCH bpf-next 3/5] bpf: Replace bpf_cpumask_any* with bpf_cpumask_any

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6f4402cd-3f05-373c-93c3-581491fd5116@meta.com>
Date:   Mon, 12 Jun 2023 08:22:01 -0700
From:   Yonghong Song <yhs@...a.com>
To:     David Vernet <void@...ifault.com>, bpf@...r.kernel.org
Cc:     ast@...nel.org, daniel@...earbox.net, andrii@...nel.org,
        martin.lau@...ux.dev, song@...nel.org, yhs@...com,
        john.fastabend@...il.com, kpsingh@...nel.org, sdf@...gle.com,
        haoluo@...gle.com, jolsa@...nel.org, linux-kernel@...r.kernel.org,
        kernel-team@...a.com, tj@...nel.org
Subject: Re: [PATCH bpf-next 3/5] bpf: Replace bpf_cpumask_any* with
 bpf_cpumask_any_distribute*



On 6/9/23 8:50 PM, David Vernet wrote:
> We currently export the bpf_cpumask_any() and bpf_cpumask_any_and()
> kfuncs. Intuitively, one would expect these to choose any CPU in the
> cpumask, but what they actually do is alias to cpumask_first() and
> cpmkas_first_and().
> 
> This is useless given that we already export bpf_cpumask_first() and
> bpf_cpumask_first_and(), so this patch replaces them with kfuncs that
> call cpumask_any_distribute() and cpumask_any_and_distribute(), which
> actually choose any CPU from the cpumask (or the AND of two cpumasks for
> the latter).
> 
> Signed-off-by: David Vernet <void@...ifault.com>

Acked-by: Yonghong Song <yhs@...com>