linux-kernel - RE: [PATCH v2] cpufreq: amd-pstate: Set default governor to schedutil

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CYYPR12MB86556045C209552FF99C47C89C54A@CYYPR12MB8655.namprd12.prod.outlook.com>
Date:   Mon, 12 Jun 2023 16:11:56 +0000
From:   "Yuan, Perry" <Perry.Yuan@....com>
To:     Viresh Kumar <viresh.kumar@...aro.org>
CC:     "rafael.j.wysocki@...el.com" <rafael.j.wysocki@...el.com>,
        "Huang, Ray" <Ray.Huang@....com>,
        "Limonciello, Mario" <Mario.Limonciello@....com>,
        "Sharma, Deepak" <Deepak.Sharma@....com>,
        "Karny, Wyes" <Wyes.Karny@....com>,
        "Shenoy, Gautham Ranjal" <gautham.shenoy@....com>,
        "Li, Sun peng (Leo)" <Sunpeng.Li@....com>,
        "Huang, Shimmer" <Shimmer.Huang@....com>,
        "Du, Xiaojian" <Xiaojian.Du@....com>,
        "Meng, Li (Jassmine)" <Li.Meng@....com>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2] cpufreq: amd-pstate: Set default governor to schedutil

[AMD Official Use Only - General]

Hi Viresh.

> -----Original Message-----
> From: Viresh Kumar <viresh.kumar@...aro.org>
> Sent: Monday, June 12, 2023 3:26 PM
> To: Yuan, Perry <Perry.Yuan@....com>
> Cc: rafael.j.wysocki@...el.com; Huang, Ray <Ray.Huang@....com>;
> Limonciello, Mario <Mario.Limonciello@....com>; Sharma, Deepak
> <Deepak.Sharma@....com>; Karny, Wyes <Wyes.Karny@....com>;
> Shenoy, Gautham Ranjal <gautham.shenoy@....com>; Li, Sun peng (Leo)
> <Sunpeng.Li@....com>; Huang, Shimmer <Shimmer.Huang@....com>;
> Du, Xiaojian <Xiaojian.Du@....com>; Meng, Li (Jassmine)
> <Li.Meng@....com>; linux-pm@...r.kernel.org; linux-
> kernel@...r.kernel.org
> Subject: Re: [PATCH v2] cpufreq: amd-pstate: Set default governor to
> schedutil
>
> On 11-06-23, 23:03, Perry Yuan wrote:
> > From: Mario Limonciello <mario.limonciello@....com>
> >
> > The Kconfig currently defaults the governor to schedutil on x86_64
> > only when intel-pstate and SMP have been selected.
> >
> > If the kernel is built only with amd-pstate, the default governor
> > should also be schedutil.
> >
> > Cc: Sun Peng (Leo) Li <sunpeng.li@....com>
> > Signed-off-by: Mario Limonciello <mario.limonciello@....com>
> > Reviewed-by: Leo Li <sunpeng.li@....com>
> > Acked-by: Huang Rui <ray.huang@....com>
> > Tested-by: Perry Yuan <Perry.Yuan@....com>
> > ---
> >  drivers/cpufreq/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig index
> > 2c839bd2b051..a1c51abddbc5 100644
> > --- a/drivers/cpufreq/Kconfig
> > +++ b/drivers/cpufreq/Kconfig
> > @@ -38,7 +38,7 @@ choice
> >     prompt "Default CPUFreq governor"
> >     default CPU_FREQ_DEFAULT_GOV_USERSPACE if
> ARM_SA1110_CPUFREQ
> >     default CPU_FREQ_DEFAULT_GOV_SCHEDUTIL if ARM64 || ARM
> > -   default CPU_FREQ_DEFAULT_GOV_SCHEDUTIL if X86_INTEL_PSTATE
> && SMP
> > +   default CPU_FREQ_DEFAULT_GOV_SCHEDUTIL if
> (X86_INTEL_PSTATE ||
> > +X86_AMD_PSTATE) && SMP
> >     default CPU_FREQ_DEFAULT_GOV_PERFORMANCE
> >     help
> >       This option sets which CPUFreq governor shall be loaded at
>
> Acked-by: Viresh Kumar <viresh.kumar@...aro.org>
>
> --
> Viresh

Thank you help to provide the ack flag.
I have added it to the V3.

Perry.