linux-kernel - Re: [v1,1/1] watchdog: sp5100_tco: support Hygon FCH/SCH (Server Controller Hub)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c55875f2-31e2-2dd8-c949-aaa6b06b62ee@roeck-us.net>
Date:   Mon, 12 Jun 2023 09:38:46 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     a345351830@...il.com, 345351830@...com
Cc:     amy.shih@...antech.com.tw, oakley.ding@...antech.com.tw,
        zhijun.hu@...antech.com.cn,
        Yuechao Zhao <yuechao.zhao@...antech.com.cn>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>,
        linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [v1,1/1] watchdog: sp5100_tco: support Hygon FCH/SCH (Server
 Controller Hub)

On 6/11/23 20:19, a345351830@...il.com wrote:
> From: Yuechao Zhao <yuechao.zhao@...antech.com.cn>
> 
> Add PCI_VENDOR_ID_HYGON(Hygon vendor id [0x1d94]) in this driver
> 
> Signed-off-by: Yuechao Zhao <yuechao.zhao@...antech.com.cn>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>   drivers/watchdog/sp5100_tco.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/watchdog/sp5100_tco.c b/drivers/watchdog/sp5100_tco.c
> index 14f8d8d90920..2bd3dc25cb03 100644
> --- a/drivers/watchdog/sp5100_tco.c
> +++ b/drivers/watchdog/sp5100_tco.c
> @@ -96,7 +96,7 @@ static enum tco_reg_layout tco_reg_layout(struct pci_dev *dev)
>   	    sp5100_tco_pci->device == PCI_DEVICE_ID_AMD_KERNCZ_SMBUS &&
>   	    sp5100_tco_pci->revision >= AMD_ZEN_SMBUS_PCI_REV) {
>   		return efch_mmio;
> -	} else if (dev->vendor == PCI_VENDOR_ID_AMD &&
> +	} else if ((dev->vendor == PCI_VENDOR_ID_AMD || dev->vendor == PCI_VENDOR_ID_HYGON) &&
>   	    ((dev->device == PCI_DEVICE_ID_AMD_HUDSON2_SMBUS &&
>   	     dev->revision >= 0x41) ||
>   	    (dev->device == PCI_DEVICE_ID_AMD_KERNCZ_SMBUS &&
> @@ -579,6 +579,8 @@ static const struct pci_device_id sp5100_tco_pci_tbl[] = {
>   	  PCI_ANY_ID, },
>   	{ PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_KERNCZ_SMBUS, PCI_ANY_ID,
>   	  PCI_ANY_ID, },
> +	{ PCI_VENDOR_ID_HYGON, PCI_DEVICE_ID_AMD_KERNCZ_SMBUS, PCI_ANY_ID,
> +	  PCI_ANY_ID, },
>   	{ 0, },			/* End of list */
>   };
>   MODULE_DEVICE_TABLE(pci, sp5100_tco_pci_tbl);