[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZIdQ723G8/a0tNEZ@nixie71>
Date: Mon, 12 Jun 2023 12:07:59 -0500
From: Jeff LaBundy <jeff@...undy.com>
To: Neil Armstrong <neil.armstrong@...aro.org>
Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Bastien Nocera <hadess@...ess.net>,
Hans de Goede <hdegoede@...hat.com>,
Henrik Rydberg <rydberg@...math.org>,
linux-input@...r.kernel.org, linux-arm-msm@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH RFC 4/4] input: touchscreen: add SPI support for Goodix
Berlin Touchscreen IC
Hi Neil,
[...]
> > > +static const struct input_id goodix_berlin_spi_input_id = {
> > > + .bustype = BUS_SPI,
> > > + .vendor = 0x0416,
> > > + .product = 0x1001,
> >
> > After having seen these in the I2C counterpart; consider defining them
> > in goodix_berlin.h.
>
> To be honest, I blindly copied it from goodix.c because the vendor
> driver puts random values here.
>
> input_dev->id.product = 0xDEAD;
> input_dev->id.vendor = 0xBEEF;
>
> So what should I set ?
If there is no explicit guidance from the vendor, I would simply leave
these unassigned; in theory one would imagine that this controller would
have a different product ID than other models.
[...]
Kind regards,
Jeff LaBundy
Powered by blists - more mailing lists