linux-kernel - Re: [PATCH v2] cgroup: Do not corrupt task iteration when rebinding subsystem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZIdV_dDDKZazcO6p@slm.duckdns.org>
Date:   Mon, 12 Jun 2023 07:29:33 -1000
From:   Tejun Heo <tj@...nel.org>
To:     Xiu Jianfeng <xiujianfeng@...weicloud.com>
Cc:     lizefan.x@...edance.com, hannes@...xchg.org, mkoutny@...e.com,
        cgroups@...r.kernel.org, linux-kernel@...r.kernel.org,
        cuigaosheng1@...wei.com
Subject: Re: [PATCH v2] cgroup: Do not corrupt task iteration when rebinding
 subsystem

On Sat, Jun 10, 2023 at 05:26:43PM +0800, Xiu Jianfeng wrote:
> From: Xiu Jianfeng <xiujianfeng@...wei.com>
> 
> We found a refcount UAF bug as follows:
...
> To fix this issue, switch from all css_sets to only scgrp's css_sets to
> patch in-flight iterators to preserve correct iteration, and then
> update it->cset_head as well.
> 
> Reported-by: Gaosheng Cui <cuigaosheng1@...wei.com>
> Link: https://www.spinics.net/lists/cgroups/msg37935.html
> Suggested-by: Michal Koutný <mkoutny@...e.com>
> Link: https://lore.kernel.org/all/20230526114139.70274-1-xiujianfeng@huaweicloud.com/
> Signed-off-by: Xiu Jianfeng <xiujianfeng@...wei.com>

Applied to cgroup/for-6.14-fixes w/ stable tag added.

Thanks.

-- 
tejun