linux-kernel - Re: [PATCH net-next] ice: Remove managed memory usage in ice_get_fw_log

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALs4sv2KYY5pg58QY-tuRtw8XNOHqLXvg9AZx+MPjePWcZ4-+A@mail.gmail.com>
Date:   Mon, 12 Jun 2023 10:17:20 +0530
From:   Pavan Chebbi <pavan.chebbi@...adcom.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     Jesse Brandeburg <jesse.brandeburg@...el.com>,
        Tony Nguyen <anthony.l.nguyen@...el.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org, intel-wired-lan@...ts.osuosl.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH net-next] ice: Remove managed memory usage in ice_get_fw_log_cfg()

On Mon, Jun 12, 2023 at 2:14 AM Christophe JAILLET
<christophe.jaillet@...adoo.fr> wrote:
>
> There is no need to use managed memory allocation here. The memory is
> released at the end of the function.
>
> You kzalloc()/kfree() to simplify the code.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
>  drivers/net/ethernet/intel/ice/ice_common.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Looks good to me.
Reviewed-by: Pavan Chebbi <pavan.chebbi@...adcom.com>

>
> diff --git a/drivers/net/ethernet/intel/ice/ice_common.c b/drivers/net/ethernet/intel/ice/ice_common.c
> index eb2dc0983776..4b799a5d378a 100644
> --- a/drivers/net/ethernet/intel/ice/ice_common.c
> +++ b/drivers/net/ethernet/intel/ice/ice_common.c
> @@ -834,7 +834,7 @@ static int ice_get_fw_log_cfg(struct ice_hw *hw)
>         u16 size;
>
>         size = sizeof(*config) * ICE_AQC_FW_LOG_ID_MAX;
> -       config = devm_kzalloc(ice_hw_to_dev(hw), size, GFP_KERNEL);
> +       config = kzalloc(size, GFP_KERNEL);
>         if (!config)
>                 return -ENOMEM;
>
> @@ -857,7 +857,7 @@ static int ice_get_fw_log_cfg(struct ice_hw *hw)
>                 }
>         }
>
> -       devm_kfree(ice_hw_to_dev(hw), config);
> +       kfree(config);
>
>         return status;
>  }
> --
> 2.34.1
>
>

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4209 bytes)