linux-kernel - Re: [PATCH v4] scsi: ufs: wb: Add explicit flush

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dbdadc45-0566-3a6c-be16-ab8f1f5c7a6a@acm.org>
Date:   Mon, 12 Jun 2023 11:21:18 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     Lu Hongfei <luhongfei@...o.com>,
        Alim Akhtar <alim.akhtar@...sung.com>,
        Avri Altman <avri.altman@....com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Daniil Lunev <dlunev@...omium.org>,
        Jinyoung Choi <j-young.choi@...sung.com>,
        Bean Huo <beanhuo@...ron.com>,
        Peter Wang <peter.wang@...iatek.com>,
        open list <linux-kernel@...r.kernel.org>,
        "open list:UNIVERSAL FLASH STORAGE HOST CONTROLLER DRIVER" 
        <linux-scsi@...r.kernel.org>
Cc:     opensource.kernel@...o.com
Subject: Re: [PATCH v4] scsi: ufs: wb: Add explicit flush_threshold sysfs
 attribute

On 6/9/23 02:11, Lu Hongfei wrote:
> +What:		/sys/bus/platform/drivers/ufshcd/*/wb_flush_threshold
> +What:		/sys/bus/platform/devices/*.ufs/wb_flush_threshold
> +Date:		June 2023
> +Contact:	Lu Hongfei <luhongfei@...o.com>
> +Description:	wb_flush_threshold is a percentage that represents the threshold for flush WB.
> +		When avail_wb_buff < wb_flush_threshold, the dev will flush WB when entered H8.
> +		When avail_wb_buff >= wb_flush_threshold, it is not necessary.

"Percentage" suggests a number in the range 0..100 while the valid range is 0..10.
Please fix this.

Thanks,

Bart.