linux-kernel - Re: [PATCH 1/1] arm64: dts: imx8mp: Add coresight trace components

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZIdpo8UOg+d61xP6@lizhi-Precision-Tower-5810>
Date:   Mon, 12 Jun 2023 14:53:23 -0400
From:   Frank Li <Frank.li@....com>
To:     Alexander Stein <alexander.stein@...tq-group.com>
Cc:     imx@...ts.linux.dev, Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>,
        open list <linux-kernel@...r.kernel.org>,
        coresight@...ts.linaro.org
Subject: Re: [PATCH 1/1] arm64: dts: imx8mp: Add coresight trace components

On Fri, Jun 09, 2023 at 10:20:16AM +0200, Alexander Stein wrote:
> > +			};
> > +		};
> > +
> > +		etf@...04000 {
> 
> The reference manual states "CXTMC_ETB" for this address. I don't have much 
> knowledge about coresight, but ETB is not the same as ETF, right? Which one is 
> correct?
> 
> Best regards,
> Alexander
> 

coresight tmc driver can auto detect etb and etf according to register value.

Frank


> > +			compatible = "arm,coresight-tmc", 
> "arm,primecell";
> > +			reg = <0x28c04000 0x1000>;
> > +			clocks = <&clk IMX8MP_CLK_MAIN_AXI>;
> > +			clock-names = "apb_pclk";
> > +			in-ports {
> > +				port {
> > +					etf_in_port: endpoint {
> > +						remote-endpoint =