linux-kernel - Re: [ PATCH v2 0/3] Add Loongson I2S controller support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <31bd1de1-feb7-4544-aca6-cfb983722057@sirena.org.uk>
Date:   Mon, 12 Jun 2023 20:07:15 +0100
From:   Mark Brown <broonie@...nel.org>
To:     YingKun Meng <mengyingkun@...ngson.cn>
Cc:     lgirdwood@...il.com, krzysztof.kozlowski+dt@...aro.org,
        linux-kernel@...r.kernel.org, alsa-devel@...a-project.org,
        loongarch@...ts.linux.dev, loongson-kernel@...ts.loongnix.cn
Subject: Re: [ PATCH v2 0/3] Add Loongson I2S controller support

On Mon, Jun 12, 2023 at 04:50:48PM +0800, YingKun Meng wrote:
> Hi all,
> 
> This patchset adds support for Loongson I2S controller, and
> introduce a ASoC machine driver for loongson platform.
> 
> The Loongson I2S controller is available on Loongson
> 7a2000/2k2000 chips, works as a PCI device. It has two
> private DMA controllers used to playback and capture.
> Each DMA controller has one channel.
> 
> The ASoC machine driver adds support for audio device which
> using loongson I2S controller to tranfser the audio data.
> The audio device uses "PRP0001" as its ACPI device ID, which
> provides a means to use the existing DT-compatible device
> identification in ACPI.

The code here all looks broadly good - I did have a few review comments
that I sent in reply to the individual patches but they're more
stylistic than anything too substantial.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)