linux-kernel - Re: [PATCH] HID: sensor-hub: Allow multi-function sensor devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51dfdee66713e470d9a925ac5a8f8ae1da644462.camel@linux.intel.com>
Date:   Sun, 11 Jun 2023 21:53:51 -0700
From:   srinivas pandruvada <srinivas.pandruvada@...ux.intel.com>
To:     Jiri Kosina <jikos@...nel.org>,
        Daniel Thompson <daniel.thompson@...aro.org>
Cc:     Jonathan Cameron <jic23@...nel.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Bjorn Andersson <andersson@...nel.org>,
        linux-input@...r.kernel.org, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: sensor-hub: Allow multi-function sensor devices

On Fri, 2023-06-09 at 17:43 +0200, Jiri Kosina wrote:
> On Sun, 28 May 2023, Daniel Thompson wrote:
> 
> > The Lenovo Yoga C630 has a combined keyboard and accelerometer that
> > interfaces via i2c-hid. Currently this laptop either has a working
> > keyboard (if CONFIG_HID_SENSOR_HUB is disabled) or a working
> > accelerometer.
> > only works on kernels. Put another way, most distro kernels enable
> > CONFIG_HID_SENSOR_HUB and therefore cannot work on this device
> > since the
> > keyboard doesn't work!
> > 
> > Fix this by providing a richer connect mask during the probe. With
> > this
> > change both keyboard and screen orientation sensors work correctly.
> > 
> > Signed-off-by: Daniel Thompson <daniel.thompson@...aro.org>
> 
> Srinivas, are you aware of any multi-function device that this patch
> might 
> break?
I tried two systems, one with ISH and another with external hub.
Didn't break anything.
I don't have 5+ years old systems, to confirm if it will break
something on older systems with external hub.

Thanks,
Srinivas

> 
> Thanks,
>