linux-kernel - Re: [EXTERNAL] Re: [PATCH v5 4/4] ASoC: dt-bindings: Add tas2781 amplifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <303B184A-1A35-4049-97F5-90D17FE990DA@ti.com>
Date:   Mon, 12 Jun 2023 20:57:42 +0000
From:   "Ding, Shenghao" <shenghao-ding@...com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
CC:     Shenghao Ding <13916275206@....com>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "perex@...ex.cz" <perex@...ex.cz>,
        "pierre-louis.bossart@...ux.intel.com" 
        <pierre-louis.bossart@...ux.intel.com>,
        "Lu, Kevin" <kevin-lu@...com>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Xu, Baojun" <x1077012@...com>, "Gupta, Peeyush" <peeyush@...com>,
        "Navada Kanyana, Mukund" <navada@...com>,
        "gentuser@...il.com" <gentuser@...il.com>,
        "Ryan_Chu@...tron.com" <Ryan_Chu@...tron.com>,
        "Sam_Wu@...tron.com" <Sam_Wu@...tron.com>,
        "tiwai@...e.de" <tiwai@...e.de>
Subject: Re: [EXTERNAL] Re: [PATCH v5 4/4] ASoC: dt-bindings: Add tas2781
 amplifier



> 在 2023年6月11日，00:33，Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> 写道：
> 
> On 10/06/2023 16:18, Shenghao Ding wrote:
>> Create tas2781.yaml for tas2781 driver.
>> 
>> Signed-off-by: Shenghao Ding <13916275206@....com>
> 
> We keep telling you that your email threading is broken. It still is
> makes reviewers life more difficult. Maintainer as well as applying is
> not straightforward.
> 
> Why this is not improved?
> 
Sorry for causing difficulties. Would you be so kind and tell me how to avoid threading broken? I get the threading broken issue every time, but I really have no idea of how to fix it.
>> 
>> ---
>> Changes in v5:
>> - remove ti,broadcast-addr
>> - remove address-cells
>> - remove size-cells
>> - put compatible item first in properties
>> - change the maxItems of reg from 4 to 8
>> - remove white space around <>
>> - correct the reg format to <0x38>, <0x3a> etc
>> - remove '\t' in the file
>> - correct a comment in the example
>> ---
>> .../devicetree/bindings/sound/ti,tas2781.yaml | 73 +++++++++++++++++++
>> 1 file changed, 73 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/sound/ti,tas2781.yaml
>> 
>> diff --git a/Documentation/devicetree/bindings/sound/ti,tas2781.yaml b/Documentation/devicetree/bindings/sound/ti,tas2781.yaml
>> new file mode 100644
>> index 000000000000..61db14a39630
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/sound/ti,tas2781.yaml
>> @@ -0,0 +1,73 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +# Copyright (C) 2022 - 2023 Texas Instruments Incorporated
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/sound/ti,tas2781.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Texas Instruments TAS2781 SmartAMP
>> +
>> +maintainers:
>> +  - Shenghao Ding <shenghao-ding@...com>
>> +
>> +description:
>> +  The TAS2781 is a mono, digital input Class-D audio amplifier
>> +  optimized for efficiently driving high peak power into small
>> +  loudspeakers. Integrated an on-chip DSP supports Texas Instruments
>> +  Smart Amp speaker protection algorithm. The integrated speaker
>> +  voltage and current sense provides for real time
>> +  monitoring of loudspeaker behavior.
>> +
>> +allOf:
>> +  - $ref: dai-common.yaml#
>> +
>> +properties:
>> +  compatible:
>> +    enum:
>> +      - ti,tas2781
>> +
>> +  reg:
>> +    description:
>> +      I2C address, in multiple tas2781s case, all the i2c address
>> +      aggreate as one Audio Device to support multiple audio slots.
>> +    maxItems: 8
>> +    items:
>> +      minimum: 0x38
>> +      maximum: 0x3f
> 
> It does not look like you tested the bindings, at least after quick
> look. Please run `make dt_binding_check` (see
> Documentation/devicetree/bindings/writing-schema.rst for instructions).
> 
Kindly point my mistake, I run the commands from the Documentation/devicetree/bindings/writing-schema.rst before submission.
For dt_binding_check, command as follow, no issue reported,
make DT_CHECKER_FLAGS=-m O= O=build_dir/x86 dt_binding_check -j $(expr $(nproc) - 1) 2>&1 | tee $OUTPUT_DIR1/$OUTPUT_DIR2/dt_binding_check.log
……………
  DTEX    Documentation/devicetree/bindings/sound/samsung,tm2.example.dts
  DTEX    Documentation/devicetree/bindings/sound/ti,tas2781.example.dts
  DTEX    Documentation/devicetree/bindings/sound/amlogic,t9015.example.dts
……………..
  DTC_CHK Documentation/devicetree/bindings/sound/samsung,tm2.example.dtb
  DTC_CHK Documentation/devicetree/bindings/sound/ti,tas2781.example.dtb
  DTC_CHK Documentation/devicetree/bindings/sound/amlogic,t9015.example.dtb
……………..

As to “make dtbs_checktest”, it can’t work in default compiling system(x86) at all. In order to test the bindings, it was integrated into the BeagleBoneBlack compiling system.
Command as follow:
make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- DT_CHECKER_FLAGS=-m KCONFIG_CONFIG=config_dir/bbb_dt_config O=build_dir/dt dtbs_check -j $(expr $(nproc) - 1) 2>&1 | tee build_dir/dt/dtbs_check.log
Only two lines have something to do with the tas2781 from dtbs_check, it is platform issue, not tas2781 bindings
  DTC_CHK arch/arm/boot/dts/am335x-evm.dtb
  DTC_CHK arch/arm/boot/dts/am335x-evmsk.dtb
  DTC_CHK arch/arm/boot/dts/am335x-guardian.dtb
/usr/local/src/linux-dt/arch/arm/boot/dts/am33xx-l4.dtsi:1467.5-28: Warning (interrupts_property): /ocp/interconnect@...00000/segment@...000/target-module@...00/i2c@...as2781@3a:#interrupt-cells: size is (4), expected multiple of 8
/usr/local/src/linux-dt/arch/arm/boot/dts/am33xx-l4.dtsi:1467.5-28: Warning (interrupts_property): /ocp/interconnect@...00000/segment@...000/target-module@...00/i2c@...asdevice@3a:#interrupt-cells: size is (4), expected multiple of 8
/usr/local/src/linux-dt/build_dir/dt/arch/arm/boot/dts/am335x-boneblue.dtb: /: fixedregulator@2: 'anyOf' conditional fail

> You miss here minItems.
> 
> 
> Best regards,
> Krzysztof
>