linux-kernel - Re: [PATCHv2] selftests: damon: add config file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b9dd402c-d8d6-e6e9-f17b-304a1dc8a578@linuxfoundation.org>
Date:   Mon, 12 Jun 2023 16:32:10 -0600
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     SeongJae Park <sj@...nel.org>
Cc:     akpm@...ux-foundation.org,
        Anders Roxell <anders.roxell@...aro.org>, shuah@...nel.org,
        linux-kernel@...r.kernel.org, damon@...ts.linux.dev,
        linux-mm@...ck.org, linux-kselftest@...r.kernel.org,
        Naresh Kamboju <naresh.kamboju@...aro.org>,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCHv2] selftests: damon: add config file

On 6/9/23 13:16, SeongJae Park wrote:
> On Wed, 12 Apr 2023 16:58:06 +0000 SeongJae Park <sj@...nel.org> wrote:
> 
>> Hi Anders,
>>
>> On Wed, 12 Apr 2023 11:28:54 +0200 Anders Roxell <anders.roxell@...aro.org> wrote:
>>
>>> Building and running the subsuite 'damon' of kselftest, shows the
>>> following issues:
>>>   selftests: damon: debugfs_attrs.sh
>>>    /sys/kernel/debug/damon not found
>>>
>>> By creating a config file enabling DAMON fragments in the
>>> selftests/damon/ directory the tests pass.
>>>
>>> Fixes: b348eb7abd09 ("mm/damon: add user space selftests")
>>> Reported-by: Naresh Kamboju <naresh.kamboju@...aro.org>
>>
>> checkpatch.pl is warning as below:
>>
>>      WARNING: Reported-by: should be immediately followed by Link: with a URL to the report
>>      #20:
>>      Reported-by: Naresh Kamboju <naresh.kamboju@...aro.org>
>>      Signed-off-by: Anders Roxell <anders.roxell@...aro.org>
>>
>> The reason for the warning can be found from commit d7f1d71e5ef6 ("checkpatch:
>> warn when Reported-by: is not followed by Link:")'s commit message.  Do you
>> have a link to put here?  I guess the report was made inside Linaro, so might
>> have no publicly available link.  Maybe better to add some notes or some funny
>> tag like "Link: N/A # no publicly-available link of the report" for convincing
>> the tool, but I don't think this should be a blocker for this patch.
>>
>>> Signed-off-by: Anders Roxell <anders.roxell@...aro.org>
>>
>> Reviewed-by: SeongJae Park <sj@...nel.org>
> 
> Shuah, may I ask your opinion on this patch?
> 
> I'm also cc-ing Andrew, as he may also interested in picking this patch.
> 

If Andrew wants to pick this up:

Acked-by: Shuah Khan <skhan@...uxfoundation.org>

thanks,
-- Shuah