linux-kernel - Re: [PATCH] selftests/ftace: Fix KTAP output ordering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 12 Jun 2023 14:33:16 +0900
From:   Masami Hiramatsu (Google) <mhiramat@...nel.org>
To:     Mark Brown <broonie@...nel.org>
Cc:     Steven Rostedt <rostedt@...dmis.org>,
        Shuah Khan <shuah@...nel.org>,
        Shuah Khan <skhan@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org,
        linux-kselftest@...r.kernel.org
Subject: Re: [PATCH] selftests/ftace: Fix KTAP output ordering

On Sat, 10 Jun 2023 15:27:55 +0100
Mark Brown <broonie@...nel.org> wrote:

> The KTAP parser I used to test the KTAP output for ftracetest was overly
> robust and did not notice that the test number and pass/fail result were
> reversed. Fix this.

Oops, I also missed that part. According to the Documentation/dev-tools/ktap.rst,
the result string ('ok', 'not ok') must be the first item.

Acked-by: Masami Hiramatsu (Google) <mhiramat@...nel.org>

Shuah, could you pick this?

Thank you,

> 
> Fixes: dbcf76390eb9 ("elftests/ftrace: Improve integration with kselftest runner")
> Signed-off-by: Mark Brown <broonie@...nel.org>
> ---
>  tools/testing/selftests/ftrace/ftracetest | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/ftrace/ftracetest b/tools/testing/selftests/ftrace/ftracetest
> index 2506621e75df..cb5f18c06593 100755
> --- a/tools/testing/selftests/ftrace/ftracetest
> +++ b/tools/testing/selftests/ftrace/ftracetest
> @@ -301,7 +301,7 @@ ktaptest() { # result comment
>      comment="# $comment"
>    fi
>  
> -  echo $CASENO $result $INSTANCE$CASENAME $comment
> +  echo $result $CASENO $INSTANCE$CASENAME $comment
>  }
>  
>  eval_result() { # sigval
> 
> ---
> base-commit: dbcf76390eb9a65d5d0c37b0cd57335218564e37
> change-id: 20230609-ftrace-ktap-order-d5b64a74dc79
> 
> Best regards,
> -- 
> Mark Brown <broonie@...nel.org>
> 


-- 
Masami Hiramatsu (Google) <mhiramat@...nel.org>