linux-kernel - Re: [PATCH] fs: Fix comment typo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 12 Jun 2023 09:00:41 +0700
From:   Bagas Sanjaya <bagasdotme@...il.com>
To:     Matthew Wilcox <willy@...radead.org>,
        Jonathan Corbet <corbet@....net>
Cc:     Shaomin Deng <dengshaomin@...rlc.com>, viro@...iv.linux.org.uk,
        brauner@...nel.org, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org, Mao Zhu <zhumao001@...suo.com>
Subject: Re: [PATCH] fs: Fix comment typo

On Sun, Jun 11, 2023 at 09:07:22PM +0100, Matthew Wilcox wrote:
> On Sun, Jun 11, 2023 at 01:50:34PM -0600, Jonathan Corbet wrote:
> > Bagas Sanjaya <bagasdotme@...il.com> writes:
> > 
> > > On Sun, Jun 11, 2023 at 08:33:14AM -0400, Shaomin Deng wrote:
> > >> From: Mao Zhu <zhumao001@...suo.com>
> > >> 
> > >> Delete duplicated word in comment.
> > >
> > > On what function?
> > 
> > Bagas, do I *really* have to ask you, yet again, to stop nitpicking our
> > contributors into the ground?  It appears I do.  So:
> > 
> > Bagas, *stop* this.  It's a typo patch removing an extraneous word.  The
> > changelog is fine.  We absolutely do not need you playing changelog cop
> > and harassing contributors over this kind of thing.
> 
> Amen.
> 

Amen too. Hope I can learn from this.

> > >> Signed-off-by: Mao Zhu <zhumao001@...suo.com>
> > >
> > > You're carrying someone else's patch, so besides SoB from original
> > > author, you need to also have your own SoB.
> > 
> > This, instead, is a valid problem that needs to be fixed.
> 
> I mean ... yes, technically, it does.  But it's a change that deletes
> a word in a comment.  Honestly, I'd take the patch without any kind of
> sign-off.  It doesn't create any copyright claim, which is the purpose
> of the DCO.

What? Relaxed SoB requirement for trivial patches like this? I thought
that SoB rules also apply to these patches.

Thanks.

-- 
An old man doll... just what I always wanted! - Clara

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)