linux-kernel - Re: [PATCH 2/3] thermal: qoriq_thermal: only enable supported sensors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <23120696.6Emhk5qWAg@pliszka>
Date:   Mon, 12 Jun 2023 08:23:34 +0200
From:   Sebastian Krzyszkowiak <sebastian.krzyszkowiak@...i.sm>
To:     Peng Fan <peng.fan@....com>,
        "Peng Fan (OSS)" <peng.fan@....nxp.com>,
        "rafael@...nel.org" <rafael@...nel.org>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        Daniel Lezcano <daniel.lezcano@...aro.org>
Cc:     "amitk@...nel.org" <amitk@...nel.org>,
        "rui.zhang@...el.com" <rui.zhang@...el.com>,
        "andrew.smirnov@...il.com" <andrew.smirnov@...il.com>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        dl-linux-imx <linux-imx@....com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        Alice Guo <alice.guo@....com>
Subject: Re: [PATCH 2/3] thermal: qoriq_thermal: only enable supported sensors

On środa, 7 czerwca 2023 21:10:18 CEST Daniel Lezcano wrote:
> On 07/06/2023 19:42, Sebastian Krzyszkowiak wrote:
> 
> [ ... ]
> 
> >> Hence, the thermal_zone_device_register_with_trips() is not called, the
> >> thermal zone is not created neither updated.
> > 
> > Again - that's not the case the check is there for. It's there for zones
> > that do exist and that do get registered, because REGS_TMR only gets set
> > *after* all the zones are already registered (the driver as it is right
> > now does not know which sites it should enable before registering the
> > zones). Because of that, the first value a zone gets after being
> > registered is always bogus, because no monitoring site has been enabled
> > yet at all.
> 
> Ok, I misunderstood. I thought that was for failing registered thermal zone.
> 
> Would enabling the site in ops->change_mode do the trick ?

Haven't tested, but from a quick glance at the core I believe it should!

Peng, would you like to try that approach out and update this patch?

Thanks,
Sebastian