linux-kernel - Re: [PATCH] time: clocksource-wdtest: Remove unnecessary initialization of variable 'ret'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 12 Jun 2023 09:40:26 +0200
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Li zeming <zeming@...china.com>, jstultz@...gle.com,
        sboyd@...nel.org, linux-kernel@...r.kernel.org
Cc:     Li zeming <zeming@...china.com>
Subject: Re: [PATCH] time: clocksource-wdtest: Remove unnecessary
 initialization of variable 'ret'

Li!

On Wed, Jun 14 2023 at 03:35, Li zeming wrote:

Can you please pick the proper prefixes and not create random ones.

https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#patch-subject

> ret is assigned first, so it does not need to initialize the
> assignment.

This sentence does not make sense. You cannot initialize an
assignment. What you want to say is something like this.

'ret' is always assigned before being checked, so initializing the
variable is not required.

No?

Thanks,

        tglx