linux-kernel - RE: [PATCH v3] cdx: Rename MCDI_LOGGING to CDX_MCDI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DM4PR12MB7765FB53636A9036F64364168F54A@DM4PR12MB7765.namprd12.prod.outlook.com>
Date:   Mon, 12 Jun 2023 08:10:09 +0000
From:   "Gangurde, Abhijit" <abhijit.gangurde@....com>
To:     Greg KH <gregkh@...uxfoundation.org>
CC:     "Agarwal, Nikhil" <nikhil.agarwal@....com>,
        "Gupta, Nipun" <Nipun.Gupta@....com>,
        "geert@...ux-m68k.org" <geert@...ux-m68k.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "git (AMD-Xilinx)" <git@....com>,
        "Simek, Michal" <michal.simek@....com>
Subject: RE: [PATCH v3] cdx: Rename MCDI_LOGGING to CDX_MCDI_LOGGING

[AMD Official Use Only - General]

> On Tue, Jun 06, 2023 at 07:31:37PM +0530, Abhijit Gangurde wrote:
> > MCDI_LOGGING is too generic considering other MCDI users
> > SFC_MCDI_LOGGING and SFC_SIENA_MCDI_LOGGING. Rename it to
> > CDX_MCDI_LOGGING makes it more domain specific.
> >
> > Also, move CONFIG_CDX_MCDI_LOGGING to header file.
> >
> > Fixes: eb96b740192b ("cdx: add MCDI protocol interface for firmware
> interaction")
> > Signed-off-by: Abhijit Gangurde <abhijit.gangurde@....com>
> > Suggested-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> > Closes:
> https://lore.kernel.org/lkml/CAMuHMdWTCdQagFFANygMgA8D0sWaoGxWv
> 2AjibC3vwSd0UxuRw@...l.gmail.com/
> > ---
> >  Changes v2->v3:
> >  - Dropped sysfs entry changes from v2
>
> Where is patch 2/2 in this series that moves to use dynamic debugging
> instead of this custom mess?
>
> This shouln't be a config option at all, as no one will be able to
> enable it on a real system.
>

Will send v4 with completely removing custom logging and use the dynamic debugging.

Thanks,
Abhijit