linux-kernel - Re: [PATCH] ASoC: mediatek: mt8173: Fix error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <178ec977-5be3-4b2a-bb24-1286be68baf2@kadam.mountain>
Date:   Mon, 12 Jun 2023 11:12:45 +0300
From:   Dan Carpenter <dan.carpenter@...aro.org>
To:     Ricardo Ribalda Delgado <ribalda@...omium.org>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, stable@...nel.org
Subject: Re: [PATCH] ASoC: mediatek: mt8173: Fix error path

On Mon, Jun 12, 2023 at 09:49:32AM +0200, Ricardo Ribalda Delgado wrote:
> @@ -1175,14 +1179,11 @@ static int mt8173_afe_pcm_dev_probe(struct platform_device *pdev)
>  	if (ret)
>  		goto err_cleanup_components;
>  
> -	irq_id = platform_get_irq(pdev, 0);
> -	if (irq_id <= 0)
> -		return irq_id < 0 ? irq_id : -ENXIO;
>  	ret = devm_request_irq(afe->dev, irq_id, mt8173_afe_irq_handler,
>  			       0, "Afe_ISR_Handle", (void *)afe);
>  	if (ret) {
>  		dev_err(afe->dev, "could not request_irq\n");
> -		goto err_pm_disable;
> +		goto err_cleanup_components;

Hm...  I hadn't noticed that.  You're right, but I don't think your
patch goes far enough.  I think everything after the first
successful call to snd_soc_add_component() should be goto
err_cleanup_components;

But I am not 100% sure.

regards,
dan carpenter

>  	}
>