linux-kernel - Re: [PATCH] fs: Fix comment typo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 12 Jun 2023 10:34:55 +0200
From:   Christian Brauner <brauner@...nel.org>
To:     Jonathan Corbet <corbet@....net>
Cc:     Bagas Sanjaya <bagasdotme@...il.com>,
        Shaomin Deng <dengshaomin@...rlc.com>, viro@...iv.linux.org.uk,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        Mao Zhu <zhumao001@...suo.com>
Subject: Re: [PATCH] fs: Fix comment typo

On Mon, Jun 12, 2023 at 08:34:53AM +0200, Christian Brauner wrote:
> On Sun, Jun 11, 2023 at 01:50:34PM -0600, Jonathan Corbet wrote:
> > Bagas Sanjaya <bagasdotme@...il.com> writes:
> > 
> > > On Sun, Jun 11, 2023 at 08:33:14AM -0400, Shaomin Deng wrote:
> > >> From: Mao Zhu <zhumao001@...suo.com>
> > >> 
> > >> Delete duplicated word in comment.
> > >
> > > On what function?
> > 
> > Bagas, do I *really* have to ask you, yet again, to stop nitpicking our
> > contributors into the ground?  It appears I do.  So:
> > 
> > Bagas, *stop* this.  It's a typo patch removing an extraneous word.  The
> > changelog is fine.  We absolutely do not need you playing changelog cop
> > and harassing contributors over this kind of thing.
> 
> 100% agreed.
> 
> > 
> > >> Signed-off-by: Mao Zhu <zhumao001@...suo.com>
> > >
> > > You're carrying someone else's patch, so besides SoB from original
> > > author, you need to also have your own SoB.
> > 
> > This, instead, is a valid problem that needs to be fixed.
> 
> Patch picked up and missing sender SOB added.

I've been informed that I may not be allowed to do that.
So dropping the sender SOB for now following willy's argument.