linux-kernel - Re: [PATCH] memory tier: remove unneeded !IS_ENABLED(CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <15095aec-4ed3-c16b-55b3-e7122652a897@redhat.com>
Date:   Mon, 12 Jun 2023 11:15:38 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Miaohe Lin <linmiaohe@...wei.com>, akpm@...ux-foundation.org
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] memory tier: remove unneeded
 !IS_ENABLED(CONFIG_MIGRATION) check

On 10.06.23 05:41, Miaohe Lin wrote:
> establish_demotion_targets() is defined while CONFIG_MIGRATION is
> enabled. There's no need to check it again.
> 
> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>
> ---
>   mm/memory-tiers.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c
> index dd04f0ce5277..a516e303e304 100644
> --- a/mm/memory-tiers.c
> +++ b/mm/memory-tiers.c
> @@ -366,7 +366,7 @@ static void establish_demotion_targets(void)
>   
>   	lockdep_assert_held_once(&memory_tier_lock);
>   
> -	if (!node_demotion || !IS_ENABLED(CONFIG_MIGRATION))
> +	if (!node_demotion)
>   		return;
>   
>   	disable_all_demotion_targets();

Reviewed-by: David Hildenbrand <david@...hat.com>

-- 
Cheers,

David / dhildenb