linux-kernel - Re: [PATCH] sched: rt: Remove unnecessary ‘NULL’ values from push

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <xhsmhttvdxch7.mognet@vschneid.remote.csb>
Date:   Mon, 12 Jun 2023 10:21:24 +0100
From:   Valentin Schneider <vschneid@...hat.com>
To:     Li zeming <zeming@...china.com>, mingo@...hat.com,
        peterz@...radead.org, juri.lelli@...hat.com,
        vincent.guittot@...aro.org, dietmar.eggemann@....com,
        rostedt@...dmis.org, bsegall@...gle.com, mgorman@...e.de,
        bristot@...hat.com
Cc:     linux-kernel@...r.kernel.org, Li zeming <zeming@...china.com>
Subject: Re: [PATCH] sched: rt: Remove unnecessary ‘NULL’ values from push_task

On 11/05/23 07:54, Li zeming wrote:
> push_task is assigned first, so it does not need to initialize the
> assignment.
>
> Signed-off-by: Li zeming <zeming@...china.com>

Subject would be clearer as "Remove unnecessary initialization", but
regardless:

Reviewed-by: Valentin Schneider <vschneid@...hat.com>

> ---
>  kernel/sched/rt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
> index 662c565745fd..55e480d5174a 100644
> --- a/kernel/sched/rt.c
> +++ b/kernel/sched/rt.c
> @@ -2073,7 +2073,7 @@ static int push_rt_task(struct rq *rq, bool pull)
>       }
>
>       if (is_migration_disabled(next_task)) {
> -		struct task_struct *push_task = NULL;
> +		struct task_struct *push_task;
>               int cpu;
>
>               if (!pull || rq->push_busy)
> --
> 2.18.2