[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <0642f96559182c76548990cac383fbb110f8d56b.camel@linux.intel.com>
Date: Mon, 12 Jun 2023 06:34:00 -0700
From: srinivas pandruvada <srinivas.pandruvada@...ux.intel.com>
To: Jiri Kosina <jikos@...nel.org>
Cc: Daniel Thompson <daniel.thompson@...aro.org>,
Jonathan Cameron <jic23@...nel.org>,
Benjamin Tissoires <benjamin.tissoires@...hat.com>,
Bjorn Andersson <andersson@...nel.org>,
linux-input@...r.kernel.org, linux-iio@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: sensor-hub: Allow multi-function sensor devices
On Mon, 2023-06-12 at 09:39 +0200, Jiri Kosina wrote:
> On Sun, 11 Jun 2023, srinivas pandruvada wrote:
>
> > > > The Lenovo Yoga C630 has a combined keyboard and accelerometer
> > > > that
> > > > interfaces via i2c-hid. Currently this laptop either has a
> > > > working
> > > > keyboard (if CONFIG_HID_SENSOR_HUB is disabled) or a working
> > > > accelerometer. only works on kernels. Put another way, most
> > > > distro
> > > > kernels enable CONFIG_HID_SENSOR_HUB and therefore cannot work
> > > > on
> > > > this device since the keyboard doesn't work!
> > > >
> > > > Fix this by providing a richer connect mask during the probe.
> > > > With
> > > > this change both keyboard and screen orientation sensors work
> > > > correctly.
> > > >
> > > > Signed-off-by: Daniel Thompson <daniel.thompson@...aro.org>
> > >
> > > Srinivas, are you aware of any multi-function device that this
> > > patch
> > > might break?
> > I tried two systems, one with ISH and another with external hub.
> > Didn't
> > break anything. I don't have 5+ years old systems, to confirm if it
> > will
> > break something on older systems with external hub.
>
> Thanks a lot. Can I take the above as an equivalent of
>
> Acked-by: Srinivas Pandruvada
> <srinivas.pandruvada@...ux.intel.com>
Sure.
Acked-by: Srinivas Pandruvada<srinivas.pandruvada@...ux.intel.com>
>
Thanks,
Srinivas
> ? :)
>
Powered by blists - more mailing lists