[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <c38a4071-d5f9-4afb-8bc0-7944c5261071@kadam.mountain>
Date: Mon, 12 Jun 2023 16:47:04 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Peter Zijlstra <peterz@...radead.org>
Cc: torvalds@...ux-foundation.org, keescook@...omium.org,
gregkh@...uxfoundation.org, pbonzini@...hat.com,
masahiroy@...nel.org, nathan@...nel.org, ndesaulniers@...gle.com,
nicolas@...sle.eu, catalin.marinas@....com, will@...nel.org,
vkoul@...nel.org, trix@...hat.com, ojeda@...nel.org,
mingo@...hat.com, longman@...hat.com, boqun.feng@...il.com,
dennis@...nel.org, tj@...nel.org, cl@...ux.com, acme@...nel.org,
mark.rutland@....com, alexander.shishkin@...ux.intel.com,
jolsa@...nel.org, namhyung@...nel.org, irogers@...gle.com,
adrian.hunter@...el.com, juri.lelli@...hat.com,
vincent.guittot@...aro.org, dietmar.eggemann@....com,
rostedt@...dmis.org, bsegall@...gle.com, mgorman@...e.de,
bristot@...hat.com, vschneid@...hat.com, paulmck@...nel.org,
frederic@...nel.org, quic_neeraju@...cinc.com,
joel@...lfernandes.org, josh@...htriplett.org,
mathieu.desnoyers@...icios.com, jiangshanlai@...il.com,
rientjes@...gle.com, vbabka@...e.cz, roman.gushchin@...ux.dev,
42.hyeyoo@...il.com, apw@...onical.com, joe@...ches.com,
dwaipayanray1@...il.com, lukas.bulwahn@...il.com,
john.johansen@...onical.com, paul@...l-moore.com,
jmorris@...ei.org, serge@...lyn.com, linux-kbuild@...r.kernel.org,
linux-kernel@...r.kernel.org, dmaengine@...r.kernel.org,
llvm@...ts.linux.dev, linux-perf-users@...r.kernel.org,
rcu@...r.kernel.org, linux-security-module@...r.kernel.org,
tglx@...utronix.de, ravi.bangoria@....com, error27@...il.com,
luc.vanoostenryck@...il.com
Subject: Re: [PATCH v3 06/57] sched: Simplify sysctl_sched_uclamp_handler()
On Mon, Jun 12, 2023 at 11:07:19AM +0200, Peter Zijlstra wrote:
> @@ -1810,7 +1811,7 @@ static int sysctl_sched_uclamp_handler(s
> if (result)
> goto undo;
> if (!write)
> - goto done;
> + return result;
This would be nicer as a "return 0;"
>
> if (sysctl_sched_uclamp_util_min > sysctl_sched_uclamp_util_max ||
> sysctl_sched_uclamp_util_max > SCHED_CAPACITY_SCALE ||
> @@ -1846,16 +1847,12 @@ static int sysctl_sched_uclamp_handler(s
> * Otherwise, keep it simple and do just a lazy update at each next
> * task enqueue time.
> */
> -
> - goto done;
> + return result;
This is a return 0 as well.
regards,
dan carpenter
>
> undo:
> sysctl_sched_uclamp_util_min = old_min;
> sysctl_sched_uclamp_util_max = old_max;
> sysctl_sched_uclamp_util_min_rt_default = old_min_rt;
> -done:
> - mutex_unlock(&uclamp_mutex);
> -
> return result;
> }
Powered by blists - more mailing lists