linux-kernel - Re: [PATCH] net: phy: Add sysfs attribute for PHY c45 identifiers.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <062bc2c3-fb3b-43d1-b1d5-4eff754cfe47@lunn.ch>
Date:   Mon, 12 Jun 2023 16:10:31 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Jianhui Zhao <zhaojh329@...il.com>
Cc:     davem@...emloft.net, edumazet@...gle.com, hkallweit1@...il.com,
        kuba@...nel.org, linux-kernel@...r.kernel.org,
        linux@...linux.org.uk, netdev@...r.kernel.org, pabeni@...hat.com
Subject: Re: [PATCH] net: phy: Add sysfs attribute for PHY c45 identifiers.

On Mon, Jun 12, 2023 at 10:04:26PM +0800, Jianhui Zhao wrote:
> diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
> index 17d0d0555a79..81a4bc043ee2 100644
> --- a/drivers/net/phy/phy_device.c
> +++ b/drivers/net/phy/phy_device.c
> @@ -541,8 +541,10 @@ static int phy_bus_match(struct device *dev, struct device_driver *drv)
>  
>  			if ((phydrv->phy_id & phydrv->phy_id_mask) ==
>  			    (phydev->c45_ids.device_ids[i] &
> -			     phydrv->phy_id_mask))
> +			     phydrv->phy_id_mask)) {
> +				phydev->phy_id = phydev->c45_ids.device_ids[i];
>  				return 1;
> +			}
>  		}
>  		return 0;
>  	} else {
> 
> How about modifying it like this?

O.K.

Please update the sysfs documentation as well.

       Andrew