linux-kernel - Re: [PATCH] remoteproc: stm32: use correct format strings on 64-bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <ba58f0cb-3683-4aae-8c10-2fad2e701501@app.fastmail.com>
Date:   Mon, 12 Jun 2023 16:17:19 +0200
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Arnaud POULIQUEN" <arnaud.pouliquen@...s.st.com>,
        "Arnd Bergmann" <arnd@...nel.org>,
        "Bjorn Andersson" <andersson@...nel.org>,
        "Mathieu Poirier" <mathieu.poirier@...aro.org>,
        "Maxime Coquelin" <mcoquelin.stm32@...il.com>,
        "Alexandre Torgue" <alexandre.torgue@...s.st.com>
Cc:     "Ben Levinsky" <ben.levinsky@....com>,
        "Tanmay Shah" <tanmay.shah@....com>,
        Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
        "Dan Carpenter" <dan.carpenter@...aro.org>,
        linux-remoteproc@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] remoteproc: stm32: use correct format strings on 64-bit

On Mon, Jun 12, 2023, at 16:10, Arnaud POULIQUEN wrote:

>>  	ddata->rsc_va = devm_ioremap_wc(dev, rsc_pa, RSC_TBL_SIZE);
>>  	if (IS_ERR_OR_NULL(ddata->rsc_va)) {
>> -		dev_err(dev, "Unable to map memory region: %pa+%zx\n",
>> +		dev_err(dev, "Unable to map memory region: %pa+%x\n",
>>  			&rsc_pa, RSC_TBL_SIZE);
>
> What about cast the RSC_TBL_SIZE define instead to ensure to be independent from
> the arch and to match with the use of RSC_TBL_SIZE?
>
> #define RSC_TBL_SIZE		((size_t)1024)

I have no objection to that, but I don't see it doing anything good either,
as this is a constant value that will always work.

     Arnd