[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <c23e1fb3628bf0a32bd0eb491c9370b961e19fd1.camel@mediatek.com>
Date: Mon, 12 Jun 2023 14:21:06 +0000
From: Wei-chin Tsai (蔡維晉)
<Wei-chin.Tsai@...iatek.com>
To: "willy@...radead.org" <willy@...radead.org>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Mel Lee (李奇錚) <Mel.Lee@...iatek.com>,
"linux-mediatek@...ts.infradead.org"
<linux-mediatek@...ts.infradead.org>,
"linux@...linux.org.uk" <linux@...linux.org.uk>,
wsd_upstream <wsd_upstream@...iatek.com>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
"matthias.bgg@...il.com" <matthias.bgg@...il.com>,
Ivan Tseng (曾志軒)
<ivan.tseng@...iatek.com>,
"angelogioacchino.delregno@...labora.com"
<angelogioacchino.delregno@...labora.com>
Subject: Re: [PATCH v1 1/1] memory: export symbols for process memory related
functions
On Sat, 2023-06-10 at 01:21 +0100, Matthew Wilcox wrote:
>
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> On Fri, Jun 09, 2023 at 04:09:01PM +0000, Wei-chin Tsai (蔡維晉) wrote:
> > > You haven't included any users of these new exports, so the
> initial
> > > reaction is going to be negative - please include the users of
> these
> > > new symbols in your patch set.
> > We use these two export functions from our kernel module to get a
> > specific user process's memory information and heap usage.
> Furthermore,
> > we can use such information to detect the memory leak issues.
> >
> > The example code is as follows:
>
> No. You need to be submitting the code that will use the symbol *at
> the
> same time* as the patch to export the symbol. No example code
> showing
> how it could be used. Because if the user isn't compelling, the
> patch
> to export the symbol won't be applied either.
Hi Matthew,
Got it. The following attached patch file
"v1-0001-memory-export-symbols-for-process-memory-related-.patch" is
the patch including the users of these new symbols. Thanks.
Regards,
Jim
View attachment "v1-0001-memory-export-symbols-for-process-memory-related-.patch" of type "text/x-patch" (28708 bytes)
Powered by blists - more mailing lists