linux-kernel - Re: [PATCH v2] regmap: Add debugfs file for forcing field writes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5b20509c-e4d5-21f8-fc20-4d02b9abd87d@axis.com>
Date:   Tue, 13 Jun 2023 17:15:10 +0200 (CEST)
From:   Ricard Wanderlof <ricardw@...s.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     Waqar Hameed <waqar.hameed@...s.com>,
        Mark Brown <broonie@...nel.org>, <kernel@...s.com>,
        <linux-kernel@...r.kernel.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>
Subject: Re: [PATCH v2] regmap: Add debugfs file for forcing field writes

On Tue, 13 Jun 2023, Greg Kroah-Hartman wrote:

> On Tue, Jun 13, 2023 at 01:42:27PM +0200, Waqar Hameed wrote:
> > `_regmap_update_bits()` checks if the current register value differs
> > from the new value, and only writes to the register if they differ. When
> >
> > +	/*
> > +	 * This could interfere with driver operation. Therefore, don't provide
> > +	 * any real compile time configuration option for this feature. One will
> > +	 * have to modify the source code directly in order to use it.
> > +	 */
> > +#undef REGMAP_ALLOW_FORCE_WRITE_FIELD_DEBUGFS
> > +#ifdef REGMAP_ALLOW_FORCE_WRITE_FIELD_DEBUGFS
> > +	debugfs_create_bool("force_write_field", 0600, map->debugfs,
> > +			    &map->force_write_field);
> > +#endif
> 
> Please no, that means this will never ever ever get used, and if it
> happens to break the build or runtime, no one will ever notice it.
> 
> If you need this for your device/tree/distro, great, just keep it as an
> out-of-tree patch with the huge header "NEVER ENABLE THIS IN A REAL
> SYSTEM" or something like that.

The ordinary only-write-if-bits-have-changed behavior of 
_regmap_update_bits would seem to be mostly an optimization to minimize 
the number of writes to a device. The way it is normally used in the code, 
it's not easy to predict when it in fact will result in a write, because 
the whole idea of a function like this is that a driver doesn't have to 
keep track of which bits are actually set or not, or else the function 
would not be useful in the first place.

I can understand that enabling a write-always behavior results in a 
different behavior on the associated bus (e.g. I2C), but in the end it 
shouldn't affect the functionality of the peripheral device any more than 
rearranging driver code to perform regmap writes in a different order, 
which might also lead to fewer or more bus writes.

It seems I'm clearly in the wrong here, so there must be some scenario 
I've missed. It just doesn't seem that dangerous; it's a debug 
functionality after all.

/Ricard
-- 
Ricard Wolf Wanderlof                           ricardw(at)axis.com
Axis Communications AB, Lund, Sweden            www.axis.com
Phone +46 46 272 2016                           Fax +46 46 13 61 30