linux-kernel - Re: [PATCH v5 25/25] arm64: dts: rockchip: rk3588s: Add DFI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230613161933.qy3qh7ybf3azl3aa@mercury.elektranox.org>
Date:   Tue, 13 Jun 2023 18:19:33 +0200
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Sascha Hauer <s.hauer@...gutronix.de>
Cc:     linux-rockchip@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-pm@...r.kernel.org, Heiko Stuebner <heiko@...ech.de>,
        Kyungmin Park <kyungmin.park@...sung.com>,
        MyungJoo Ham <myungjoo.ham@...sung.com>,
        Will Deacon <will@...nel.org>,
        Mark Rutland <mark.rutland@....com>, kernel@...gutronix.de,
        Michael Riesch <michael.riesch@...fvision.net>,
        Robin Murphy <robin.murphy@....com>,
        Vincent Legoll <vincent.legoll@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>, devicetree@...r.kernel.org
Subject: Re: [PATCH v5 25/25] arm64: dts: rockchip: rk3588s: Add DFI

Hi,

On Wed, May 24, 2023 at 10:31:53AM +0200, Sascha Hauer wrote:
> The DFI unit can be used to measure DRAM utilization using perf. Add the
> node to the device tree. The DFI needs a rockchip,pmu phandle to the pmu
> containing registers for SDRAM configuration details. This is added in
> this patch as well.
> 
> Signed-off-by: Sascha Hauer <s.hauer@...gutronix.de>
> ---
> 
> Notes:
>     Changes since v4:
>     - new patch
> 
>  arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
> index 657c019d27fa9..4a445d8704c8f 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
> @@ -388,6 +388,11 @@ scmi_shmem: sram@0 {
>  		};
>  	};
>  
> +	pmu1grf: syscon@...8a000 {
> +		compatible = "rockchip,rk3588-pmugrf", "syscon", "simple-mfd";
                      ^^^^^^^^^^^^^^^^^^^^^^

Must be added in Documentation/devicetree/bindings/soc/rockchip/grf.yaml

Otherwise the patch is

Reviewed-by: Sebastian Reichel <sebastian.reichel@...labora.com>

-- Sebastian

> +		reg = <0x0 0xfd58a000 0x0 0x10000>;
> +	};
> +
>  	sys_grf: syscon@...8c000 {
>  		compatible = "rockchip,rk3588-sys-grf", "syscon";
>  		reg = <0x0 0xfd58c000 0x0 0x1000>;
> @@ -1112,6 +1117,17 @@ qos_vop_m1: qos@...82200 {
>  		reg = <0x0 0xfdf82200 0x0 0x20>;
>  	};
>  
> +	dfi: dfi@...60000 {
> +		reg = <0x00 0xfe060000 0x00 0x10000>;
> +		compatible = "rockchip,rk3588-dfi";
> +		interrupts = <GIC_SPI 28 IRQ_TYPE_LEVEL_HIGH 0>,
> +			     <GIC_SPI 38 IRQ_TYPE_LEVEL_HIGH 0>,
> +			     <GIC_SPI 48 IRQ_TYPE_LEVEL_HIGH 0>,
> +			     <GIC_SPI 58 IRQ_TYPE_LEVEL_HIGH 0>;
> +		interrupt-names = "ch0", "ch1", "ch2", "ch3";
> +		rockchip,pmu = <&pmu1grf>;
> +	};
> +
>  	gmac1: ethernet@...c0000 {
>  		compatible = "rockchip,rk3588-gmac", "snps,dwmac-4.20a";
>  		reg = <0x0 0xfe1c0000 0x0 0x10000>;
> -- 
> 2.39.2
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)