linux-kernel - Re: [PATCH v13 08/10] clk: nuvoton: Add clock driver for ma35d1 clock controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Tue, 13 Jun 2023 10:19:52 +0800
From:   Jacky Huang <ychuang570808@...il.com>
To:     Stephen Boyd <sboyd@...nel.org>, catalin.marinas@....com,
        gregkh@...uxfoundation.org, jirislaby@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, lee@...nel.org,
        mturquette@...libre.com, p.zabel@...gutronix.de,
        robh+dt@...nel.org, tmaimon77@...il.com, will@...nel.org
Cc:     devicetree@...r.kernel.org, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-serial@...r.kernel.org, arnd@...db.de, soc@...nel.org,
        schung@...oton.com, mjchen@...oton.com,
        Jacky Huang <ychuang3@...oton.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Subject: Re: [PATCH v13 08/10] clk: nuvoton: Add clock driver for ma35d1 clock
 controller



On 2023/6/13 上午 10:16, Stephen Boyd wrote:
> Quoting Jacky Huang (2023-06-12 18:37:31)
>> On 2023/6/13 上午 09:02, Stephen Boyd wrote:
>>> Quoting Jacky Huang (2023-06-04 21:07:47)
>>>> diff --git a/drivers/clk/nuvoton/clk-ma35d1-divider.c b/drivers/clk/nuvoton/clk-ma35d1-divider.c
>>>> +                                           int num_pdata)
>>>> +{
>>>> +       return clk_hw_register_mux_parent_data(dev, name, pdata, num_pdata,
>>>> +                                              CLK_SET_RATE_NO_REPARENT, reg, shift,
>>>> +                                              width, 0, &ma35d1_lock);
>>>> +}
>>>> +
>>>> +static struct clk_hw *ma35d1_clk_mux(struct device *dev, const char *name,
>>>> +                                    void __iomem *reg, u8 shift, u8 width,
>>>> +                                    const char *const *parents, int num_parents)
>>> Please don't use string arrays for parent descriptions. Everything
>>> should use clk_parent_data or direct clk_hw pointers.
>> I will use clk_parent_data instead of strings.
>>
> When you use clk_parent_data, just don't set anything for the "dummy"
> clks besides a -1 .index to indicate there isn't a parent for that
> entry.


Okay, thank you for the reminder.

Best Regards,
Jacky Huang